[fix] nn.Embedding.from_pretrained : honour padding_idx argument#47184
Closed
kshitij12345 wants to merge 2 commits intopytorch:masterfrom
Closed
[fix] nn.Embedding.from_pretrained : honour padding_idx argument#47184kshitij12345 wants to merge 2 commits intopytorch:masterfrom
padding_idx argument#47184kshitij12345 wants to merge 2 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 7b12a05 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
albanD
approved these changes
Nov 2, 2020
Collaborator
albanD
left a comment
There was a problem hiding this comment.
Thanks for taking the time to update this!
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #47184 +/- ##
=======================================
Coverage 60.81% 60.81%
=======================================
Files 2748 2748
Lines 254027 254030 +3
=======================================
+ Hits 154488 154494 +6
+ Misses 99539 99536 -3 |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#47184) Summary: Fixes pytorch#46585 (first snippet) Now the behaviour of `padding_idx` agrees with documentation. Pull Request resolved: pytorch#47184 Reviewed By: mruberry Differential Revision: D24682567 Pulled By: albanD fbshipit-source-id: 864bd34eb9099d367a3fcbb8f4f4ba2e2b270724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46585 (first snippet)
Now the behaviour of
padding_idxagrees with documentation.