Skip to content

Expand the test of torch.bmm on CUDA#47070

Closed
zasdfgbnm wants to merge 2 commits intomasterfrom
baddmm-tests
Closed

Expand the test of torch.bmm on CUDA#47070
zasdfgbnm wants to merge 2 commits intomasterfrom
baddmm-tests

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented Oct 29, 2020 •
edited
Loading

This is to satisfy the request at #42553 (comment), see also #47079 #47080

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Oct 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 04f53da (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) <confirmed not flaky by 2 failures>

AssertionError: "expected scalar type" does not match "CUDA error: misaligned address" 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 274, in instantiated_test 
    result = test_fn(self, *args) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 652, in only_fn 
    return fn(self, device, *args, **kwargs) 
  File "test_torch.py", line 18945, in test_where_scalar_invalid_combination_raises 
    self._test_where_scalar_template(device, dtype, checkRaises) 
  File "test_torch.py", line 18921, in _test_where_scalar_template 
    exec_fn(scalar_type, dtype, condition, x, scalar_1) 
  File "test_torch.py", line 18943, in checkRaises 
    torch.where(condition, x, scalar_1) 
AssertionError: "expected scalar type" does not match "CUDA error: misaligned address" 
 
---------------------------------------------------------------------- 
Ran 7769 tests in 443.602s 
 
FAILED (failures=43, errors=1632, skipped=218, expected failures=4) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestDevicePrecisionCUDA-20201029194831.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTensorDeviceOpsCPU-20201029194831.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTensorDeviceOpsCUDA-20201029194831.xml
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

This was referenced Oct 29, 2020
Closed
Closed
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 29, 2020
@zasdfgbnm zasdfgbnm mentioned this pull request Oct 29, 2020
Closed
@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

zasdfgbnm commented Oct 30, 2020

@pytorchbot retest this please

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

Hi @zasdfgbnm!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@zasdfgbnm zasdfgbnm mentioned this pull request Oct 30, 2020
Closed
@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

zasdfgbnm commented Oct 30, 2020

deprecated in favor of #47124

@ngimel ngimel closed this Oct 30, 2020
@zasdfgbnm zasdfgbnm deleted the baddmm-tests branch October 30, 2020 23:22
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2020
@zasdfgbnm @facebook-github-bot
Expand the test of torch.bmm on CUDA (#47124)
030caa1 
Summary:
basically #47070, enabled on all CI with `ci-all`

Pull Request resolved: #47124

Reviewed By: ejguan

Differential Revision: D24735130

Pulled By: ngimel

fbshipit-source-id: c2124562a9f9d1caf24686e5d8a1106c79366233
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@zasdfgbnm @facebook-github-bot
Expand the test of torch.bmm on CUDA (pytorch#47124)
d9990bc 
Summary:
basically pytorch#47070, enabled on all CI with `ci-all`

Pull Request resolved: pytorch#47124

Reviewed By: ejguan

Differential Revision: D24735130

Pulled By: ngimel

fbshipit-source-id: c2124562a9f9d1caf24686e5d8a1106c79366233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel Awaiting requested review from ngimel

@anjali411 anjali411 Awaiting requested review from anjali411

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zasdfgbnm @facebook-github-bot @albanD @ngimel @pytorchbot