[pytorch] Remove c10::nullopt_t::init#47013
Closed
swolchok wants to merge 4 commits intogh/swolchok/2/basefrom
Closed
[pytorch] Remove c10::nullopt_t::init#47013swolchok wants to merge 4 commits intogh/swolchok/2/basefrom
swolchok wants to merge 4 commits intogh/swolchok/2/basefrom
Conversation
It was getting used in client code, and it's not part of `std::optional`. Differential Revision: [D24547710](https://our.internmc.facebook.com/intern/diff/D24547710/) [ghstack-poisoned]
This was referenced Oct 28, 2020
💊 CI failures summary and remediationsAs of commit 0e5344b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
It was getting used in client code, and it's not part of `std::optional`. Differential Revision: [D24547710](https://our.internmc.facebook.com/intern/diff/D24547710/) [ghstack-poisoned]
smessmer
approved these changes
Oct 29, 2020
It was getting used in client code, and it's not part of `std::optional`. Differential Revision: [D24547710](https://our.internmc.facebook.com/intern/diff/D24547710/) [ghstack-poisoned]
It was getting used in client code, and it's not part of `std::optional`. Differential Revision: [D24547710](https://our.internmc.facebook.com/intern/diff/D24547710/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 17be8ae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It was getting used in client code, and it's not part of
std::optional.Differential Revision: D24547710