Optimize torch.fft.fftn for real input with an r2c transform by peterbell10 · Pull Request #46912 · pytorch/pytorch

peterbell10 · 2020-10-27T12:12:08Z

Stack from ghstack:

Optimize torch.fft.fftn for real input with an r2c transform #46912 Optimize torch.fft.fftn for real input with an r2c transform
stft: Change require_complex warning to an error #49022 stft: Change require_complex warning to an error

ghstack-source-id: c9c727d Pull Request resolved: #46912

dr-ci · 2020-10-27T12:36:32Z

💊 CI failures summary and remediations

As of commit 06d141e (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_libtorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Dec 15 16:51:00 sccache: error: couldn't connect to server

Dec 15 16:51:00 +++ eval 'extract_trap_cmd '
Dec 15 16:51:00 ++++ extract_trap_cmd
Dec 15 16:51:00 ++++ printf '%s\n' ''
Dec 15 16:51:00 +++ printf '%s\n' cleanup
Dec 15 16:51:00 ++ trap -- '
Dec 15 16:51:00 cleanup' EXIT
Dec 15 16:51:00 ++ [[ pytorch-libtorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7-build != *pytorch-win-* ]]
Dec 15 16:51:00 ++ which sccache
Dec 15 16:51:00 ++ sccache --stop-server
Dec 15 16:51:00 Stopping sccache server...
Dec 15 16:51:00 sccache: error: couldn't connect to server
Dec 15 16:51:00 sccache: caused by: Connection refused (os error 111)
Dec 15 16:51:00 ++ true
Dec 15 16:51:00 ++ rm /var/lib/jenkins/sccache_error.log
Dec 15 16:51:00 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Dec 15 16:51:00 ++ true
Dec 15 16:51:00 ++ [[ pytorch-libtorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7-build == *rocm* ]]
Dec 15 16:51:00 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Dec 15 16:51:00 ++ SCCACHE_IDLE_TIMEOUT=1200
Dec 15 16:51:00 ++ RUST_LOG=sccache::server=error
Dec 15 16:51:00 ++ sccache --start-server

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 105 times.

ghstack-source-id: aa9a41f Pull Request resolved: #46912

ghstack-source-id: 8475a14 Pull Request resolved: #46912

ghstack-source-id: b157f27 Pull Request resolved: #46912

ghstack-source-id: 2c11285 Pull Request resolved: #46912

facebook-github-bot · 2020-10-30T17:24:45Z

Hi @peterbell10!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

mruberry · 2020-11-02T14:54:45Z

Test failures look real.

What's the performance difference with this change?

ghstack-source-id: 9bcd493 Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: 760bb86 Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: cb53a6f Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: 509b629 Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: acceb94 Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: 9a32aec Pull Request resolved: #46912

[ghstack-poisoned]

ghstack-source-id: 43003ce Pull Request resolved: #46912

peterbell10 · 2021-01-07T16:41:21Z

I'm just going to close this PR. It doesn't give a clear performance improvement in its current state and torch.fft is performing very well already.

peterbell10 added a commit that referenced this pull request Oct 27, 2020

Optimize torch.fft.fftn for real input with an r2c transform

de7bc5a

ghstack-source-id: c9c727d Pull Request resolved: #46912

pytorchbot added the open source label Oct 27, 2020

peterbell10 requested a review from mruberry October 27, 2020 12:22

peterbell10 added a commit that referenced this pull request Oct 27, 2020

Optimize torch.fft.fftn for real input with an r2c transform

eabf4f8

ghstack-source-id: aa9a41f Pull Request resolved: #46912

peterbell10 added a commit that referenced this pull request Oct 27, 2020

Optimize torch.fft.fftn for real input with an r2c transform

07e8d69

ghstack-source-id: 8475a14 Pull Request resolved: #46912

peterbell10 added a commit that referenced this pull request Oct 29, 2020

Optimize torch.fft.fftn for real input with an r2c transform

f40856a

ghstack-source-id: b157f27 Pull Request resolved: #46912

peterbell10 added a commit that referenced this pull request Oct 30, 2020

Optimize torch.fft.fftn for real input with an r2c transform

3f51957

ghstack-source-id: 2c11285 Pull Request resolved: #46912

facebook-github-bot added the cla signed label Oct 31, 2020

peterbell10 mentioned this pull request Nov 9, 2020

Use new FFT operators in stft #47601

Closed

peterbell10 added a commit that referenced this pull request Dec 2, 2020

Optimize torch.fft.fftn for real input with an r2c transform

4be1193

ghstack-source-id: 9bcd493 Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

f4a9c83

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Dec 2, 2020

Optimize torch.fft.fftn for real input with an r2c transform

2620e0a

ghstack-source-id: 760bb86 Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

b7efba3

[ghstack-poisoned]

peterbell10 mentioned this pull request Dec 6, 2020

Remove unused operator at::_fft_with_size #48905

Closed

peterbell10 added a commit that referenced this pull request Dec 6, 2020

Optimize torch.fft.fftn for real input with an r2c transform

2ae7f75

ghstack-source-id: cb53a6f Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

764759b

[ghstack-poisoned]

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

0bed42e

[ghstack-poisoned]

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

b61c135

[ghstack-poisoned]

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

7601517

[ghstack-poisoned]

peterbell10 mentioned this pull request Dec 8, 2020

stft: Change require_complex warning to an error #49022

Closed

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

d7fc72f

[ghstack-poisoned]

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

a9c1842

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Dec 8, 2020

Optimize torch.fft.fftn for real input with an r2c transform

7fa28fb

ghstack-source-id: 509b629 Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

bfb8ab3

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Dec 8, 2020

Optimize torch.fft.fftn for real input with an r2c transform

89465d4

ghstack-source-id: acceb94 Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

374d853

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Dec 9, 2020

Optimize torch.fft.fftn for real input with an r2c transform

b804bc5

ghstack-source-id: 9a32aec Pull Request resolved: #46912

Update on "Optimize torch.fft.fftn for real input with an r2c transform"

06d141e

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Dec 15, 2020

Optimize torch.fft.fftn for real input with an r2c transform

81f0f38

ghstack-source-id: 43003ce Pull Request resolved: #46912

peterbell10 closed this Jan 7, 2021

facebook-github-bot deleted the gh/peterbell10/23/head branch February 7, 2021 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize torch.fft.fftn for real input with an r2c transform#46912

Optimize torch.fft.fftn for real input with an r2c transform#46912
peterbell10 wants to merge 13 commits intogh/peterbell10/23/basefrom
gh/peterbell10/23/head

peterbell10 commented Oct 27, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Oct 27, 2020 •

edited by facebook-github-bot

Loading

Uh oh!

facebook-github-bot commented Oct 30, 2020

Uh oh!

mruberry commented Nov 2, 2020

Uh oh!

peterbell10 commented Jan 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

peterbell10 commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Oct 27, 2020 • edited by facebook-github-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_libtorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build (1/1)

Uh oh!

facebook-github-bot commented Oct 30, 2020

Uh oh!

mruberry commented Nov 2, 2020

Uh oh!

peterbell10 commented Jan 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

peterbell10 commented Oct 27, 2020 •

edited

Loading

dr-ci Bot commented Oct 27, 2020 •

edited by facebook-github-bot

Loading