Fix invalidArguments for functions with tuple outputs, but no other arguments#468
Merged
soumith merged 1 commit intopytorch:masterfrom Jan 18, 2017
Merged
Conversation
arguments.
For example:
>>> torch.randn(5, 5).geqrf('invalid arg')
TypeError: geqrf received an invalid combination of arguments - got (str), but expected ()
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Oct 3, 2019
IFU 20190911 2
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Nov 25, 2020
* Add test cases * Fix pytorch#468 * Fix thread predicate for GridReduction When TIDx/y/z are predicated, set the TIDx/y/z template flags as false Closes pytorch#367 * cleanup * clang-tidy * Delete accidentally added file * Remove unnecessary include * PR feedback * clang-format * Add a comment on GridReduction::thread_predicate_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example: