Fix device guard for c10-full ops#46091
Closed
smessmer wants to merge 5 commits intogh/smessmer/260/basefrom
Closed
Fix device guard for c10-full ops#46091smessmer wants to merge 5 commits intogh/smessmer/260/basefrom
smessmer wants to merge 5 commits intogh/smessmer/260/basefrom
Conversation
Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/) [ghstack-poisoned]
This was referenced Oct 9, 2020
Closed
💊 CI failures summary and remediationsAs of commit 925b6bb (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 21 times. |
ezyang
approved these changes
Oct 9, 2020
Contributor
|
Would have been fine to squash this into above diff. |
Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/) [ghstack-poisoned]
Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/smessmer/260/base #46091 +/- ##
========================================================
- Coverage 68.24% 68.24% -0.01%
========================================================
Files 410 410
Lines 53639 53639
========================================================
- Hits 36607 36606 -1
- Misses 17032 17033 +1
Continue to review full report at Codecov.
|
Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/) [ghstack-poisoned]
Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 69e152e. |
Contributor
|
This pull request has been merged in 69e152e. |
EmilioRivera
pushed a commit
to EmilioRivera/pytorch-bugs
that referenced
this pull request
Oct 18, 2020
Pull Request resolved: pytorch/pytorch#46091 ghstack-source-id: 114269274 Differential Revision: [D24219943](https://our.internmc.facebook.com/intern/diff/D24219943/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D24219943