Make torch.lu support complex input on CUDA.#45898
Closed
Conversation
LU support complex input on CUDA.torch.lu support complex input on CUDA.
anjali411
reviewed
Oct 8, 2020
anjali411
reviewed
Oct 8, 2020
anjali411
reviewed
Oct 8, 2020
anjali411
reviewed
Oct 8, 2020
💊 CI failures summary and remediationsAs of commit 195d9ee (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## master #45898 +/- ##
=======================================
Coverage 68.20% 68.20%
=======================================
Files 410 410
Lines 53453 53453
=======================================
Hits 36457 36457
Misses 16996 16996 Continue to review full report at Codecov.
|
anjali411
approved these changes
Oct 14, 2020
Contributor
anjali411
left a comment
There was a problem hiding this comment.
LGTM thanks @nikitaved
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@anjali411 merged this pull request in 9300a27. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
Summary: As per title. A minor fix required to make it available for the CPU (`fmod` does not support complex). For CUDA requires [#45898 ](#45898). Pull Request resolved: #45980 Reviewed By: izdeby Differential Revision: D24539097 Pulled By: anjali411 fbshipit-source-id: 508830dbfd7794ab73e19320d07c69a051c91819
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: As per title. LU decomposition is used for computing determinants, and I need this functionality to implement the matrix square root. Next PR on my list is to enable `torch.det` on CUDA with complex input. Pull Request resolved: pytorch#45898 Reviewed By: heitorschueroff Differential Revision: D24306951 Pulled By: anjali411 fbshipit-source-id: 168f578fe65ae1b978617a66741aa27e72b2172b
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: As per title. A minor fix required to make it available for the CPU (`fmod` does not support complex). For CUDA requires [pytorch#45898 ](pytorch#45898). Pull Request resolved: pytorch#45980 Reviewed By: izdeby Differential Revision: D24539097 Pulled By: anjali411 fbshipit-source-id: 508830dbfd7794ab73e19320d07c69a051c91819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title. LU decomposition is used for computing determinants, and I need this functionality to implement the matrix square root. Next PR on my list is to enable
torch.deton CUDA with complex input.