Skip to content

Added CUDA support for complex input for QR decomposition#45032

Closed
IvanYashchuk wants to merge 3 commits intopytorch:masterfrom
IvanYashchuk:qr-complex-cuda
Closed

Added CUDA support for complex input for QR decomposition#45032
IvanYashchuk wants to merge 3 commits intopytorch:masterfrom
IvanYashchuk:qr-complex-cuda

Conversation

@IvanYashchuk
Copy link
Copy Markdown
Collaborator

@IvanYashchuk IvanYashchuk commented Sep 19, 2020

QR decomposition now works for complex inputs on GPU.

Ref. #33152

@IvanYashchuk IvanYashchuk added module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul labels Sep 19, 2020
@IvanYashchuk IvanYashchuk mentioned this pull request Sep 19, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Sep 19, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a180fef (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_bionic_py3_6_clang9_test

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2020 •
edited
Loading

Codecov Report

Merging #45032 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45032   +/-   ##
=======================================
  Coverage   67.83%   67.84%           
=======================================
  Files         384      384           
  Lines       49962    49962           
=======================================
+ Hits        33892    33896    +4     
+ Misses      16070    16066    -4
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️
torch/utils/_benchmark/utils/common.py 80.16% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0714c00...a180fef. Read the comment docs.

@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 22, 2020
vishwakftw
vishwakftw approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishwakftw vishwakftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@IvanYashchuk
Copy link
Copy Markdown
Collaborator Author

IvanYashchuk commented Oct 4, 2020

@anjali411 can we merge this?

anjali411
anjali411 approved these changes Oct 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late response, I was running behind on the reviews. LGTM. my only comment would be that we should enable autograd for qr in an follow up PR

facebook-github-bot
facebook-github-bot reviewed Oct 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 8, 2020

@anjali411 merged this pull request in f010df3.

@IvanYashchuk IvanYashchuk deleted the qr-complex-cuda branch October 10, 2020 10:56
@rlucas7
Copy link
Copy Markdown
Contributor

rlucas7 commented Dec 13, 2020

sorry for the late response, I was running behind on the reviews. LGTM. my only comment would be that we should enable autograd for qr in an follow up PR

AFAICS the existing autograd for QR won't work for complex, it's missing a phase part on R matrix diagonals

@IvanYashchuk
Copy link
Copy Markdown
Collaborator Author

IvanYashchuk commented Dec 13, 2020

The derivative rule for QR was updated with #48489.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@IvanYashchuk @facebook-github-bot
Added CUDA support for complex input for QR decomposition (pytorch#45032
c26cf32 
)

Summary:
QR decomposition now works for complex inputs on GPU.

Ref. pytorch#33152

Pull Request resolved: pytorch#45032

Reviewed By: ailzhang

Differential Revision: D24199105

Pulled By: anjali411

fbshipit-source-id: 249552b31fd713446e609b66e508ac54b817b98e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

+2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@vishwakftw vishwakftw vishwakftw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@IvanYashchuk @facebook-github-bot @rlucas7 @anjali411 @vishwakftw @ailzhang @pytorchbot