Add `Ellipsis` constant to the list of recognized tokens by malfet · Pull Request #44959 · pytorch/pytorch

malfet · 2020-09-18T16:36:10Z

Per https://docs.python.org/3.6/library/constants.html

Ellipsis is the same as ellipsis literal ...

`Ellipsis` is the same as ellipsis literl `...`

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2020-09-18T19:36:29Z

What's the motivation for this? Is there a particular example of code that does not compile but should compile? We should probably add tests for this.

codecov · 2020-09-18T20:23:22Z

Codecov Report

Merging #44959 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #44959   +/-   ##
=======================================
  Coverage   67.85%   67.86%           
=======================================
  Files         384      384           
  Lines       49919    49919           
=======================================
+ Hits        33873    33876    +3     
+ Misses      16046    16043    -3

Impacted Files	Coverage Δ
torch/testing/_internal/expecttest.py	`78.57% <0.00%> (+1.02%)`	⬆️
torch/utils/_benchmark/utils/common.py	`79.33% <0.00%> (+1.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b7e44...3ae1ee1. Read the comment docs.

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

malfet · 2020-09-18T22:44:23Z

@SplitInfinity this PR is a prep for a bigger effort to add homogenous tuple support to jit script, see #44774

In particularly this PR (or #44958 ) prevents a crash while trying to parse Tuple[int, Ellipsis] type

dr-ci · 2020-09-18T22:55:30Z

💊 CI failures summary and remediations

As of commit 3ae1ee1 (more details on the Dr. CI page):

1/3 failures introduced in this PR
2/3 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 19 00:16:50 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future

Sep 19 00:16:50 At: 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 19 00:16:50  
Sep 19 00:16:50 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 19 00:16:50  
Sep 19 00:16:50 At: 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 19 00:16:50  
Sep 19 00:16:50 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 19 00:16:50  
Sep 19 00:16:50 At: 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 19 00:16:50   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 19 00:16:50  
Sep 19 00:16:50 [W tensorpipe_agent.cpp:577] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Sep 19 00:16:50 [W tensorpipe_agent.cpp:577] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Sep 19 00:16:50 [W tensorpipe_agent.cpp:577] RPC agent for worker0 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Sep 19 00:16:50 ok (1.537s) 
Sep 19 00:16:52   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:577] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)

❄️ 2 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_windows_vs2019_py36_cuda10.1_test2 (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

ModuleNotFoundError: No module named 'torch'

[ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details. 
[ERROR:VsDevCmd.bat] Where [value] is: 
[ERROR:VsDevCmd.bat]    1 : basic debug logging 
[ERROR:VsDevCmd.bat]    2 : detailed debug logging 
[ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended. 
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3 
[ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1 
Traceback (most recent call last): 
  File "run_test.py", line 13, in <module> 
    import torch 
ModuleNotFoundError: No module named 'torch' 
+ cleanup
+ retcode=1
+ set +x

pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

ModuleNotFoundError: No module named 'torch'

[ERROR:VsDevCmd.bat] Where [value] is: 
[ERROR:VsDevCmd.bat]    1 : basic debug logging 
[ERROR:VsDevCmd.bat]    2 : detailed debug logging 
[ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended. 
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3 
[ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1 
Run jit_profiling tests 
Traceback (most recent call last): 
  File "run_test.py", line 13, in <module> 
    import torch 
ModuleNotFoundError: No module named 'torch' 
+ cleanup
+ retcode=1
+ set +x

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

suo

lgtm; can we add some basic tests to ensure that the ellipsis token works as intended?

malfet · 2020-09-22T01:10:02Z

lgtm; can we add some basic tests to ensure that the ellipsis token works as intended?

@suo, will add them as part of PR that adds support for variable length Tuples.

facebook-github-bot · 2020-09-22T16:17:24Z

@malfet merged this pull request in 63fd257.

Summary: Per https://docs.python.org/3.6/library/constants.html > `Ellipsis` is the same as ellipsis literal `...` Pull Request resolved: pytorch#44959 Reviewed By: suo Differential Revision: D23785660 Pulled By: malfet fbshipit-source-id: f68461849e7d16ef68042eb96566f2c936c06b0f

Add Ellipsis constant to the list of recognized token

c75e4d9

`Ellipsis` is the same as ellipsis literl `...`

malfet requested review from SplitInfinity, ezyang and suo September 18, 2020 16:36

malfet requested a review from apaszke as a code owner September 18, 2020 16:36

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 18, 2020

facebook-github-bot reviewed Sep 18, 2020

View reviewed changes

malfet changed the title ~~Add Ellipsis constant to the list of recognized token~~ Add Ellipsis constant to the list of recognized tokens Sep 18, 2020

And add it to the parser

3ae1ee1

facebook-github-bot reviewed Sep 18, 2020

View reviewed changes

malfet mentioned this pull request Sep 18, 2020

Add support for homogenous tuples #44774

Closed

suo approved these changes Sep 21, 2020

View reviewed changes

facebook-github-bot closed this in 63fd257 Sep 22, 2020

facebook-github-bot added the merged label Sep 22, 2020

malfet deleted the malfet/jit-add-ellipsis-built-in-constant branch September 23, 2020 14:04

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Ellipsis` constant to the list of recognized tokens#44959

Add `Ellipsis` constant to the list of recognized tokens#44959
malfet wants to merge 2 commits intopytorch:masterfrom
malfet:malfet/jit-add-ellipsis-built-in-constant

malfet commented Sep 18, 2020

Uh oh!

facebook-github-bot left a comment

Uh oh!

SplitInfinity commented Sep 18, 2020

Uh oh!

codecov Bot commented Sep 18, 2020 •

edited

Loading

Uh oh!

facebook-github-bot left a comment

Uh oh!

malfet commented Sep 18, 2020

Uh oh!

dr-ci Bot commented Sep 18, 2020 •

edited

Loading

Uh oh!

suo left a comment

Uh oh!

malfet commented Sep 22, 2020

Uh oh!

facebook-github-bot commented Sep 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

malfet commented Sep 18, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

SplitInfinity commented Sep 18, 2020

Uh oh!

codecov Bot commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

malfet commented Sep 18, 2020

Uh oh!

dr-ci Bot commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

❄️ 2 failures tentatively classified as flaky

pytorch_windows_vs2019_py36_cuda10.1_test2 (1/2)

pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

Uh oh!

suo left a comment

Choose a reason for hiding this comment

Uh oh!

malfet commented Sep 22, 2020

Uh oh!

facebook-github-bot commented Sep 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Sep 18, 2020 •

edited

Loading

dr-ci Bot commented Sep 18, 2020 •

edited

Loading