Add batching rule for "is_complex", "conj"#44649
Closed
zou3519 wants to merge 5 commits intogh/zou3519/305/basefrom
Closed
Add batching rule for "is_complex", "conj"#44649zou3519 wants to merge 5 commits intogh/zou3519/305/basefrom
zou3519 wants to merge 5 commits intogh/zou3519/305/basefrom
Conversation
To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` [ghstack-poisoned]
anjali411
approved these changes
Sep 14, 2020
Closed
To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356) [ghstack-poisoned]
anjali411
reviewed
Sep 14, 2020
Contributor
anjali411
left a comment
There was a problem hiding this comment.
Looks like test_vmap is not added in this list https://github.com/pytorch/pytorch/blob/master/test/run_test.py and that's why (despite the test failures), the CI was green for #43208
Contributor
Author
Thanks for pointing that out. I've added it to run_test in #44656. Fingers crossed that there are no Windows or rocm issues... |
To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit b3442a4 (more details on the Dr. CI page):
1 job timed out:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
Codecov Report
@@ Coverage Diff @@
## gh/zou3519/305/base #44649 +/- ##
======================================================
Coverage ? 68.08%
======================================================
Files ? 384
Lines ? 49763
Branches ? 0
======================================================
Hits ? 33880
Misses ? 15883
Partials ? 0 Continue to review full report at Codecov.
|
To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356) [ghstack-poisoned]
To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356) [ghstack-poisoned]
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44649 To unblock #43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Reviewed By: anjali411 Differential Revision: D23685356 Pulled By: zou3519 fbshipit-source-id: 29e41a9296336f6d1008e3040cade4c643bf5ebf
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#44649 To unblock pytorch#43208, which adds "is_complex" checks to backward formulas that are being tested for batched gradient support with vmap. Test Plan: - `pytest test/test_vmap.py -v` Reviewed By: anjali411 Differential Revision: D23685356 Pulled By: zou3519 fbshipit-source-id: 29e41a9296336f6d1008e3040cade4c643bf5ebf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.
Test Plan:
pytest test/test_vmap.py -vDifferential Revision: D23685356