[JIT] Disallow plain List type annotation without arg#44584
Closed
SplitInfinity wants to merge 1 commit intogh/splitinfinity/44/basefrom
Closed
[JIT] Disallow plain List type annotation without arg#44584SplitInfinity wants to merge 1 commit intogh/splitinfinity/44/basefrom
SplitInfinity wants to merge 1 commit intogh/splitinfinity/44/basefrom
Conversation
**Summary** This commit extends the work done in #38130 and disallows plain Python3-style `List` type annotations. **Test Plan** This commit extends `TestList.test_no_element_type_annotation` to the Python3-style type annotation. [ghstack-poisoned]
This was referenced Sep 12, 2020
gmagogsfm
approved these changes
Sep 15, 2020
Contributor
|
@SplitInfinity merged this pull request in 78b806a. |
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44584 **Summary** This commit extends the work done in #38130 and disallows plain Python3-style `List` type annotations. **Test Plan** This commit extends `TestList.test_no_element_type_annotation` to the Python3-style type annotation. Test Plan: Imported from OSS Reviewed By: gmagogsfm Differential Revision: D23721514 Pulled By: SplitInfinity fbshipit-source-id: 48957868286f44ab6d5bf5e1bf97f0a4ebf955df
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#44584 **Summary** This commit extends the work done in pytorch#38130 and disallows plain Python3-style `List` type annotations. **Test Plan** This commit extends `TestList.test_no_element_type_annotation` to the Python3-style type annotation. Test Plan: Imported from OSS Reviewed By: gmagogsfm Differential Revision: D23721514 Pulled By: SplitInfinity fbshipit-source-id: 48957868286f44ab6d5bf5e1bf97f0a4ebf955df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit extends the work done in #38130 and disallows plain
Python3-style
Listtype annotations.Test Plan
This commit extends
TestList.test_no_element_type_annotationto thePython3-style type annotation.
Differential Revision: D23721514