Skip to content

split torch.testing._internal.* and add type checking for torch.testing._internal.common_cuda#44575

Closed
walterddr wants to merge 1 commit intomasterfrom
gh/walterddr/type_check_testing_internal_2
Closed

split torch.testing._internal.* and add type checking for torch.testing._internal.common_cuda#44575
walterddr wants to merge 1 commit intomasterfrom
gh/walterddr/type_check_testing_internal_2

Conversation

@walterddr
Copy link
Copy Markdown
Contributor

@walterddr walterddr commented Sep 11, 2020 •
edited
Loading

First step related to: #42969.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Sep 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d9a597d (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@walterddr walterddr force-pushed the gh/walterddr/type_check_testing_internal_2 branch from 0e4903d to d9a597d Compare September 12, 2020 01:50
@walterddr walterddr marked this pull request as ready for review September 12, 2020 01:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2020 •
edited
Loading

Codecov Report

Merging #44575 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44575   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         384      384           
  Lines       49567    49567           
=======================================
+ Hits        33696    33697    +1     
+ Misses      15871    15870    -1
Impacted Files Coverage Δ
torch/testing/_internal/common_cuda.py 54.05% <100.00%> (ø)
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b4477...d9a597d. Read the comment docs.

facebook-github-bot
facebook-github-bot reviewed Sep 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 15, 2020

@walterddr merged this pull request in b5dd6e3.

xwang233 added a commit that referenced this pull request Sep 16, 2020
@xwang233
try fix mypy check introduced in #44575
a3192fa
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@xuzhao9
split torch.testing._internal.* and add type checking for torch.testi…
4bad7fc 
…ng._internal.common_cuda (#44575)

Summary:
First step to fix #42969.

Pull Request resolved: #44575

Reviewed By: malfet

Differential Revision: D23668740

Pulled By: walterddr

fbshipit-source-id: eeb3650b1780aaa5727b525b4e6182e1bc47a83f
@facebook-github-bot facebook-github-bot deleted the gh/walterddr/type_check_testing_internal_2 branch January 27, 2021 18:26
emcastillo pushed a commit to emcastillo/pytorch that referenced this pull request Mar 15, 2022
@xwang233
try fix mypy check introduced in pytorch#44575
253157c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
split torch.testing._internal.* and add type checking for torch.testi…
6ad0ec7 
…ng._internal.common_cuda (pytorch#44575)

Summary:
First step to fix pytorch#42969.

Pull Request resolved: pytorch#44575

Reviewed By: malfet

Differential Revision: D23668740

Pulled By: walterddr

fbshipit-source-id: eeb3650b1780aaa5727b525b4e6182e1bc47a83f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walterddr @facebook-github-bot @malfet @mruberry