Update backward definition for more operators and reenable tests in test_ops.py#44444
Closed
anjali411 wants to merge 17 commits intogh/anjali411/54/basefrom
Closed
Update backward definition for more operators and reenable tests in test_ops.py#44444anjali411 wants to merge 17 commits intogh/anjali411/54/basefrom
anjali411 wants to merge 17 commits intogh/anjali411/54/basefrom
Conversation
…est_ops.py [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 82ad2f8 (more details on the Dr. CI page): Commit 82ad2f8 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 107 times. |
… tests in test_ops.py" [ghstack-poisoned]
… tests in test_ops.py" [ghstack-poisoned]
… tests in test_ops.py" [ghstack-poisoned]
… tests in test_ops.py" [ghstack-poisoned]
… tests in test_ops.py" [ghstack-poisoned]
…enable tests in test_ops.py" [ghstack-poisoned]
…enable tests in test_ops.py" [ghstack-poisoned]
…enable tests in test_ops.py" This PR: 1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`. 2. Re-enables the tests in `test_ops.py`. 3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 . 4. Adds dispatch for complex dtypes for `tanh`. 5. Re-enables commented tests in `common_methods_invocation.py`. [ghstack-poisoned]
…enable tests in test_ops.py" This PR: 1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`. 2. Re-enables the tests in `test_ops.py`. 3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 . 4. Adds dispatch for complex dtypes for `tanh`. 5. Re-enables commented tests in `common_methods_invocation.py`. [ghstack-poisoned]
…enable tests in test_ops.py" This PR: 1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`, `reciprocal`. 2. Re-enables the tests in `test_ops.py`. 3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 . 4. Adds dispatch for complex dtypes for `tanh_backward`. 5. Re-enables commented tests in `common_methods_invocation.py`. [ghstack-poisoned]
…enable tests in test_ops.py" This PR: 1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`, `reciprocal`. 2. Re-enables the tests in `test_ops.py`. 3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 . 4. Adds dispatch for complex dtypes for `tanh_backward`. 5. Re-enables commented tests in `common_methods_invocation.py`. [ghstack-poisoned]
Contributor
|
@anjali411 merged this pull request in 7d809f5. |
Contributor
|
Unfortunately this is failing Windows only test: |
This was referenced Oct 13, 2020
anjali411
added a commit
that referenced
this pull request
Oct 13, 2020
anjali411
added a commit
that referenced
this pull request
Oct 14, 2020
Re #44444 Fixes #46144 Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785) [ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 14, 2020
Re #44444 Fixes #46144 Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785) [ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 14, 2020
anjali411
added a commit
that referenced
this pull request
Oct 16, 2020
anjali411
added a commit
that referenced
this pull request
Oct 20, 2020
anjali411
added a commit
that referenced
this pull request
Oct 21, 2020
anjali411
added a commit
that referenced
this pull request
Oct 23, 2020
anjali411
added a commit
that referenced
this pull request
Oct 23, 2020
Re #44444 Fixes #46144 Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785) [ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 25, 2020
anjali411
added a commit
that referenced
this pull request
Oct 25, 2020
Re #44444 Fixes #46144 Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…est_ops.py (pytorch#44444) Summary: Pull Request resolved: pytorch#44444 This PR: 1. Fixes pytorch#41510. Updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`, `reciprocal`, `angle`. 2. Re-enables the tests in `test_ops.py`. 3. Adds dispatch for complex dtypes for `tanh_backward`. 4. Re-enables commented tests in `common_methods_invocation.py`. Test Plan: Imported from OSS Reviewed By: glaringlee Differential Revision: D24027761 Pulled By: anjali411 fbshipit-source-id: c1f707c2a039149a6e04bbde53ee120d9119d99a
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#46275 Re pytorch#44444 Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D24285785 Pulled By: anjali411 fbshipit-source-id: c60ecd4fe4f144132085f2c91d3b950e92b2a491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR:
asin,acos,asinh,acosh,atan,atanh,div,log,log10,log2,log1p,pow(fixes [Complex Autograd] pow_backward functions throw error for complex dtypes #41510 ),reciprocal,angle.test_ops.py.tanh_backward.common_methods_invocation.py.Differential Revision: D24027761