rename _min_max to _aminmax#44001
Closed
vkuzo wants to merge 2 commits intogh/vkuzo/140/basefrom
Closed
Conversation
Summary: This is to align with the naming in numpy and in #43092 Test Plan: ``` python test/test_torch.py TestTorchDeviceTypeCPU.test_aminmax_cpu_float32 python test/test_torch.py TestTorchDeviceTypeCUDA.test_aminmax_cuda_float32 ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 2, 2020
💊 CI failures summary and remediationsAs of commit d612e86 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
ngimel
approved these changes
Sep 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/140/base #44001 +/- ##
====================================================
Coverage ? 69.33%
====================================================
Files ? 381
Lines ? 47152
Branches ? 0
====================================================
Hits ? 32694
Misses ? 14458
Partials ? 0 Continue to review full report at Codecov.
|
Summary: This is to align with the naming in numpy and in #43092 Test Plan: ``` python test/test_torch.py TestTorchDeviceTypeCPU.test_aminmax_cpu_float32 python test/test_torch.py TestTorchDeviceTypeCUDA.test_aminmax_cuda_float32 ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23465298](https://our.internmc.facebook.com/intern/diff/D23465298) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 6a65525. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#44001 This is to align with the naming in numpy and in pytorch#43092 Test Plan: ``` python test/test_torch.py TestTorchDeviceTypeCPU.test_aminmax_cpu_float32 python test/test_torch.py TestTorchDeviceTypeCUDA.test_aminmax_cuda_float32 ``` Imported from OSS Reviewed By: jerryzh168 Differential Revision: D23465298 fbshipit-source-id: b599035507156cefa53942db05f93242a21c8d06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is to align with the naming in numpy and in
#43092
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23465298