[ONNX] Enable true_divide scripting export with ONNX shape inference#43991
Closed
BowenBao wants to merge 2 commits intopytorch:masterfrom
Closed
[ONNX] Enable true_divide scripting export with ONNX shape inference#43991BowenBao wants to merge 2 commits intopytorch:masterfrom
BowenBao wants to merge 2 commits intopytorch:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43991 +/- ##
=======================================
Coverage 69.24% 69.24%
=======================================
Files 378 378
Lines 46866 46866
=======================================
+ Hits 32453 32454 +1
+ Misses 14413 14412 -1
Continue to review full report at Codecov.
|
💊 CI failures summary and remediationsAs of commit d1ea9fc (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
neginraoof
approved these changes
Sep 4, 2020
bzinodev
approved these changes
Sep 14, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bzinodev
approved these changes
Sep 16, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
…43991) Summary: Fixes the `true_divide` symbolic to cast tensors correctly. The logic depends on knowing input types at export time, which is a known gap for exporting scripted modules. On that end we are improving exporter by enabling ONNX shape inference #40628, and starting to increase coverage for scripting support. Pull Request resolved: #43991 Reviewed By: mruberry Differential Revision: D23674614 Pulled By: bzinodev fbshipit-source-id: 1b1b85340eef641f664a14c4888781389c886a8b
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#43991) Summary: Fixes the `true_divide` symbolic to cast tensors correctly. The logic depends on knowing input types at export time, which is a known gap for exporting scripted modules. On that end we are improving exporter by enabling ONNX shape inference pytorch#40628, and starting to increase coverage for scripting support. Pull Request resolved: pytorch#43991 Reviewed By: mruberry Differential Revision: D23674614 Pulled By: bzinodev fbshipit-source-id: 1b1b85340eef641f664a14c4888781389c886a8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
true_dividesymbolic to cast tensors correctly.The logic depends on knowing input types at export time, which is a known gap for exporting scripted modules. On that end we are improving exporter by enabling ONNX shape inference #40628, and starting to increase coverage for scripting support.