Allow Tensor-likes in torch.autograd.gradcheck by hameerabbasi · Pull Request #43877 · pytorch/pytorch

hameerabbasi · 2020-08-31T11:58:13Z

Fixes #42942

dr-ci · 2020-08-31T12:13:45Z

💊 CI failures summary and remediations

As of commit cec5804 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm3.7-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 63 times.

ezyang · 2020-09-01T15:58:19Z

The overall approach looks pretty reasonable. Please ping when not WIP.

codecov · 2020-09-01T17:30:17Z

Codecov Report

Merging #43877 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #43877   +/-   ##
=======================================
  Coverage   69.24%   69.25%           
=======================================
  Files         381      381           
  Lines       47573    47580    +7     
=======================================
+ Hits        32943    32951    +8     
+ Misses      14630    14629    -1

Impacted Files	Coverage Δ
torch/autograd/__init__.py	`85.71% <100.00%> (+0.86%)`	⬆️
torch/autograd/gradcheck.py	`87.64% <100.00%> (+0.44%)`	⬆️
torch/overrides.py	`98.05% <100.00%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce5982...cec5804. Read the comment docs.

hameerabbasi · 2020-09-01T19:18:52Z

I think this is ready for review. The CI failure is unrelated: It's a bunch of connection refused errors.

albanD

The autograd part looks good to me.
I'll let @rgommers or @ezyang make a final review to make sure the override testing is doing the right thing.

albanD · 2020-09-02T14:23:26Z

+    Currently, this occurs whenever there's a ``__torch_function__``
+    attribute on the input.
+    """
+    return type(inp) is torch.Tensor or hasattr(inp, "__torch_function__")


nit: Why not use isinstance here? the type check is better?

It’s faster, I believe.

facebook-github-bot

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hameerabbasi · 2020-09-04T12:03:45Z

Do we know why the internal tests are failing? Can someone provide a repro-er and/or a traceback?

albanD · 2020-09-07T16:25:19Z

Hey,
OSS failure show up as internal failures as well, and some flaky tests.
Landing is taking a bit more time with the long week end here ;)

facebook-github-bot

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-09-10T16:13:04Z

@ezyang merged this pull request in f9a0d0c.

anjali411 · 2020-09-11T15:25:54Z

reverting this because of test failure in #43208

Sep 10 15:36:06 ======================================================================
Sep 10 15:36:06 ERROR: test_gradcheck (__main__.TestGradCheckOverride)
Sep 10 15:36:06 ----------------------------------------------------------------------
Sep 10 15:36:06 Traceback (most recent call last):
Sep 10 15:36:06   File "test_overrides.py", line 772, in test_gradcheck
Sep 10 15:36:06     gradcheck(torch.add, (a, b), raise_exception=False)
Sep 10 15:36:06   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/autograd/gradcheck.py", line 334, in gradcheck
Sep 10 15:36:06     numerical = get_numerical_jacobian(fn, tupled_inputs, eps=eps)
Sep 10 15:36:06   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/autograd/gradcheck.py", line 148, in get_numerical_jacobian
Sep 10 15:36:06     update_jacobians(x_tensor, x_idx, d_tensor, d_idx)
Sep 10 15:36:06   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/autograd/gradcheck.py", line 104, in update_jacobians
Sep 10 15:36:06     d[d_idx] = ds_dx * v
Sep 10 15:36:06 TypeError: unsupported operand type(s) for *: 'Wrapper' and 'float'

@hameerabbasi can you fix this?

This reverts commit f9a0d0c. [ghstack-poisoned]

This reverts commit f9a0d0c. ghstack-source-id: d662f56 Pull Request resolved: #44554

ezyang · 2020-09-11T15:37:13Z

Just to clarify, @hameerabbasi, I forgot that there is a high priority update being made to gradcheck right now to make it support complex numbers. This takes priority over enhanced __torch_function__ support, so it may be better to revert this PR for now, get complex gradcheck in, and then reland the gradcheck so that it handles the updated gradcheck code correctly.

I briefly looked at the error with @anjali411 but I couldn't figure out why the torch function test stopped working, even when passing non-complex inputs.

hameerabbasi · 2020-09-11T15:38:38Z

Sure. I can make those changes in a follow-up PR.

Summary: Fixes #42942 Re-do of #43877. Pull Request resolved: #45732 Reviewed By: mruberry Differential Revision: D24195820 Pulled By: albanD fbshipit-source-id: 8f43353077f341e34371affd76be553c0ef7d98a

Summary: Fixes pytorch#42942 Pull Request resolved: pytorch#43877 Reviewed By: zou3519 Differential Revision: D23493257 Pulled By: ezyang fbshipit-source-id: 6cdaabe17157b484e9491189706ccc15420ac239

Summary: Fixes pytorch#42942 Re-do of pytorch#43877. Pull Request resolved: pytorch#45732 Reviewed By: mruberry Differential Revision: D24195820 Pulled By: albanD fbshipit-source-id: 8f43353077f341e34371affd76be553c0ef7d98a

hameerabbasi requested review from albanD and apaszke as code owners August 31, 2020 11:58

hameerabbasi marked this pull request as draft August 31, 2020 11:58

hameerabbasi requested review from cpuhrsch and rgommers and removed request for apaszke August 31, 2020 11:59

pytorchbot added the open source label Aug 31, 2020

hameerabbasi force-pushed the gradcheck-override branch from 489f24b to 71e15c6 Compare August 31, 2020 13:13

albanD reviewed Aug 31, 2020

View reviewed changes

Comment thread torch/autograd/gradcheck.py Outdated

Comment thread torch/autograd/gradcheck.py Outdated

hameerabbasi force-pushed the gradcheck-override branch 3 times, most recently from 8460f7b to 588dd4a Compare September 1, 2020 11:01

hameerabbasi marked this pull request as ready for review September 1, 2020 11:02

hameerabbasi force-pushed the gradcheck-override branch 3 times, most recently from 0c1e60a to 7d2a403 Compare September 1, 2020 14:20

ezyang reviewed Sep 1, 2020

View reviewed changes

Comment thread torch/autograd/gradcheck.py Outdated

ezyang reviewed Sep 1, 2020

View reviewed changes

Comment thread torch/overrides.py Outdated

hameerabbasi force-pushed the gradcheck-override branch from 7d2a403 to 981cbee Compare September 1, 2020 16:57

hameerabbasi changed the title ~~WIP: Allow Tensor-likes in torch.autograd.gradcheck~~ Allow Tensor-likes in torch.autograd.gradcheck Sep 1, 2020

hameerabbasi requested review from albanD and ezyang September 1, 2020 19:18

albanD reviewed Sep 1, 2020

View reviewed changes

Comment thread torch/overrides.py Outdated

Allow Tensor-likes in torch.autograd.gradcheck.

860920c

hameerabbasi force-pushed the gradcheck-override branch from 981cbee to 860920c Compare September 1, 2020 19:50

hameerabbasi requested a review from albanD September 2, 2020 11:42

albanD reviewed Sep 2, 2020

View reviewed changes

smessmer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 2, 2020

ezyang reviewed Sep 3, 2020

View reviewed changes

Comment thread test/test_overrides.py

ezyang approved these changes Sep 3, 2020

View reviewed changes

facebook-github-bot reviewed Sep 3, 2020

View reviewed changes

Add commit with guidance on how the asserted API may change.

96438ad

facebook-github-bot reviewed Sep 3, 2020

View reviewed changes

hameerabbasi requested review from albanD and ezyang September 7, 2020 07:11

Merge branch 'viable/strict' into gradcheck-override

cec5804

facebook-github-bot reviewed Sep 9, 2020

View reviewed changes

facebook-github-bot closed this in f9a0d0c Sep 10, 2020

facebook-github-bot added the merged label Sep 10, 2020

ezyang added a commit that referenced this pull request Sep 11, 2020

Revert "Allow Tensor-likes in torch.autograd.gradcheck (#43877)"

7c6878f

This reverts commit f9a0d0c. [ghstack-poisoned]

ezyang mentioned this pull request Sep 11, 2020

Revert "Allow Tensor-likes in torch.autograd.gradcheck (#43877)" #44554

Closed

ezyang added a commit that referenced this pull request Sep 11, 2020

Revert "Allow Tensor-likes in torch.autograd.gradcheck (#43877)"

353ef02

This reverts commit f9a0d0c. ghstack-source-id: d662f56 Pull Request resolved: #44554

hameerabbasi deleted the gradcheck-override branch October 2, 2020 11:11

hameerabbasi mentioned this pull request Oct 8, 2020

Allow Tensor-likes in torch.autograd.gradcheck #45732

Closed

mruberry added the Merged label Oct 28, 2020

Conversation

hameerabbasi commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

ci.pytorch.org: 1 failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezyang commented Sep 1, 2020

Uh oh!

codecov Bot commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hameerabbasi commented Sep 1, 2020

Uh oh!

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

albanD Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

hameerabbasi Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

hameerabbasi commented Sep 4, 2020

Uh oh!

albanD commented Sep 7, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 10, 2020

Uh oh!

anjali411 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang commented Sep 11, 2020

Uh oh!

hameerabbasi commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hameerabbasi commented Aug 31, 2020 •

edited

Loading

dr-ci Bot commented Aug 31, 2020 •

edited

Loading

codecov Bot commented Sep 1, 2020 •

edited

Loading

anjali411 commented Sep 11, 2020 •

edited

Loading