Kill unused _pointwise_loss function.#43523
Closed
gchanan wants to merge 4 commits intogh/gchanan/301/basefrom
Closed
Kill unused _pointwise_loss function.#43523gchanan wants to merge 4 commits intogh/gchanan/301/basefrom
gchanan wants to merge 4 commits intogh/gchanan/301/basefrom
Conversation
The code is also wrong, see #43228.
💊 CI failures summary and remediationsAs of commit 86199dc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
The code is also wrong, see #43228. Differential Revision: [D23305461](https://our.internmc.facebook.com/intern/diff/D23305461)
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/301/base #43523 +/- ##
====================================================
Coverage 69.32% 69.33%
====================================================
Files 378 378
Lines 46749 46741 -8
====================================================
- Hits 32408 32406 -2
+ Misses 14341 14335 -6
Continue to review full report at Codecov.
|
This was referenced Aug 28, 2020
The code is also wrong, see #43228. Differential Revision: [D23305461](https://our.internmc.facebook.com/intern/diff/D23305461)
The code is also wrong, see #43228. Differential Revision: [D23305461](https://our.internmc.facebook.com/intern/diff/D23305461)
Contributor
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Aug 31, 2020
The code is also wrong, see pytorch#43228. ghstack-source-id: 592ee73 Pull Request resolved: pytorch#43523
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The code is also wrong, see #43228.
Differential Revision: D23305461