Fix type annotations for torch.sparse, enable in CI#43108
Closed
rgommers wants to merge 2 commits intopytorch:masterfrom
Closed
Fix type annotations for torch.sparse, enable in CI#43108rgommers wants to merge 2 commits intopytorch:masterfrom
rgommers wants to merge 2 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 88c5998 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
Failure with the correct type annotation was: ``` E RuntimeError: E Unknown type constructor Union: E File "/home/rgommers/code/pytorch/torch/sparse/__init__.py", line 86 E def sum(input: Tensor, dim: Optional[Union[int, Tuple[int], List[int]]] = None, E ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE E dtype: Optional[DType] = None) -> Tensor: E r""" E 'sum' is being compiled since it was called from 'test_sparse_sum' E File "<string>", line 2 E def test_sparse_sum(input): E return torch.sparse.sum(input) ```
ezyang
approved these changes
Aug 17, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
malfet
approved these changes
Aug 17, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Closes pytorchgh-42982 Pull Request resolved: pytorch#43108 Reviewed By: malfet Differential Revision: D23167560 Pulled By: ezyang fbshipit-source-id: 0d660ca686ada2347bf440c6349551d1539f99ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-42982