Skip to content

Compress fatbin to fit into 32bit indexing#43074

Closed
zasdfgbnm wants to merge 1 commit intomasterfrom
compress-all
Closed

Compress fatbin to fit into 32bit indexing#43074
zasdfgbnm wants to merge 1 commit intomasterfrom
compress-all

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented Aug 14, 2020

Fixes #39968

tested with TORCH_CUDA_ARCH_LIST='3.5 5.2 6.0 6.1 7.0 7.5 8.0+PTX', before this PR, it was failing, and with this PR, the build succeed.

With TORCH_CUDA_ARCH_LIST='7.0 7.5 8.0+PTX', libtorch_cuda.so with symbols changes from 2.9GB -> 2.2GB

cc: @ptrblck @mcarilli @jjsjann123

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Aug 17, 2020

It's already the case when multiarch wheels are built:
https://github.com/pytorch/builder/blob/b106a9e892d370d40000662319de74244d00b78a/manywheel/build.sh#L5

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in ee74c2e.

@facebook-github-bot facebook-github-bot deleted the compress-all branch January 27, 2021 18:26
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Fixes pytorch#39968

tested with `TORCH_CUDA_ARCH_LIST='3.5 5.2 6.0 6.1 7.0 7.5 8.0+PTX'`, before this PR, it was failing, and with this  PR, the build succeed.

With `TORCH_CUDA_ARCH_LIST='7.0 7.5 8.0+PTX'`, `libtorch_cuda.so` with symbols changes from 2.9GB -> 2.2GB

cc: ptrblck mcarilli jjsjann123

Pull Request resolved: pytorch#43074

Reviewed By: mrshenli

Differential Revision: D23176095

Pulled By: malfet

fbshipit-source-id: 7b3e6d049fc080e519f21e80df05ef68e7bea57e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/usr/bin/ld: failed to convert GOTPCREL relocation; relink with --no-relax

5 participants