Set default ATen threading backend to native if USE_OPENMP is false#43067
Set default ATen threading backend to native if USE_OPENMP is false#43067malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
There should be a simple unit-test that calls checks something like 'ATen parallel backend: OpenMP' in torch.__config__.parallel_info() for Linux and Windows and 'ATen parallel backend: native thread pool' in torch.__config__.parallel_info() for macOS
Maybe it should run only during the release
💊 CI failures summary and remediationsAs of commit 5d14fe5 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
|
@pbelevich I don't think we should have this one as a unit test since developer should be free to compile PyTorch with TBB or with OpenMP on Mac using a custom clang build. But we should add this to release runbook. |
Since OpenMP is not available on some platforms, or might be disabled by user during configuration, set ATEN_THREADING default based on USE_OPENMP and USE_TBB options
7550265 to
5d14fe5
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ytorch#43067) Summary: Since OpenMP is not available on some platforms, or might be disabled by user, set default `ATEN_THREADING` based on USE_OPENMP and USE_TBB options Fixes pytorch#43036 Pull Request resolved: pytorch#43067 Reviewed By: houseroad Differential Revision: D23138856 Pulled By: malfet fbshipit-source-id: cc8f9ee59a5559baeb3f19bf461abbc08043b71c
Since OpenMP is not available on some platforms, or might be disabled by user, set default
ATEN_THREADINGbased on USE_OPENMP and USE_TBB optionsFixes #43036