Skip to content

Fix cmake warning#42707

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-cuda-cmake-warning
Closed

Fix cmake warning#42707
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-cuda-cmake-warning

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Aug 6, 2020

If argumenets in set_target_properties are not separated by whitespace, cmake raises a warning:

CMake Warning (dev) at cmake/public/cuda.cmake:269:
  Syntax Warning in cmake code at column 54

  Argument not separated from preceding token by whitespace.

This fixes warning in CuDNN definition

If argumenets in set_target_properties are not separated by whitespace, cmake raises a warning:
```
CMake Warning (dev) at cmake/public/cuda.cmake:269:
  Syntax Warning in cmake code at column 54

  Argument not separated from preceding token by whitespace.
```
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet requested a review from ngimel August 7, 2020 00:49
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Aug 7, 2020

💊 CI failures summary and remediations

As of commit 5c65a7f (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in 31ed468.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in 31ed468.

@malfet malfet deleted the malfet/fix-cuda-cmake-warning branch August 10, 2020 23:50
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
If argumenets in set_target_properties are not separated by whitespace, cmake raises a warning:
```
CMake Warning (dev) at cmake/public/cuda.cmake:269:
  Syntax Warning in cmake code at column 54

  Argument not separated from preceding token by whitespace.
```

Fixes #{issue number}

Pull Request resolved: pytorch#42707

Reviewed By: ailzhang

Differential Revision: D22988055

Pulled By: malfet

fbshipit-source-id: c3744f23b383d603788cd36f89a8286a46b6c00f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants