Print TE CUDA kernel#42692
Conversation
[ghstack-poisoned]
| bool need_rewrite_ = false; | ||
| }; | ||
|
|
||
| std::ostream& operator<<( |
There was a problem hiding this comment.
I am not a fan of overloading "operator<<" for a generic data structure. I am perfectly fine if it is either static or within an anonymous namespace.
There was a problem hiding this comment.
I'll make this static, but I'm not sure I understand the objection?
|
|
||
| # XXX: Use if need to print something | ||
| # print(modeldef.forward.graph_for(*modeldef.inputs)) | ||
| global print_once |
There was a problem hiding this comment.
If I remember correctly, this function is called for different rnn_creator, so why a global "print_once"? I am perfectly fine if this flag is local to a particular training, and only once across all the training steps.
There was a problem hiding this comment.
Oops, this is not supposed to be here :)
💊 CI failures summary and remediationsAs of commit cc7d914 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
| int major, minor; | ||
| getMajorMinor(prop, major, minor); | ||
|
|
||
| #if DEBUG_PRINT |
There was a problem hiding this comment.
Seems kind of low-value to me, unless someone really wants it I was inclined to remove it for the sake of spamming the console less.
| return end_event.time - self.time | ||
|
|
||
|
|
||
| print_once = True |
There was a problem hiding this comment.
Changes to this file seem unrelated. Are they intentional?
[ghstack-poisoned]
Differential Revision: [D22986112](https://our.internmc.facebook.com/intern/diff/D22986112) [ghstack-poisoned]
|
@bertmaher merged this pull request in 9525268. |
Summary: Pull Request resolved: pytorch#42692 Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D22986112 Pulled By: bertmaher fbshipit-source-id: 52ec3389535c8b276858bef8c470a59aeba4946f
Stack from ghstack:
Differential Revision: D22986112