BAND, BOR and BXOR for NCCL (all_)reduce should throw runtime errors#42669
Closed
thinking-tower wants to merge 2 commits intopytorch:masterfrom
Closed
BAND, BOR and BXOR for NCCL (all_)reduce should throw runtime errors#42669thinking-tower wants to merge 2 commits intopytorch:masterfrom
thinking-tower wants to merge 2 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 1130ac4 (more details on the Dr. CI page):
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
rohan-varma
suggested changes
Aug 6, 2020
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Thanks for the contribution, it looks great! Requesting changes for the assertRaisesRegex, and there are also a couple of python lint issues. You can view those by clicking on the failed CI job (we should have inline annotations as well, but those seem to not be working right now).
rohan-varma
approved these changes
Aug 7, 2020
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Looks good, thanks @thinking-tower!
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@rohan-varma merged this pull request in 6ebc050. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#42669) Summary: cc rohan-varma Fixes pytorch#41362 pytorch#39708 # Description NCCL doesn't support `BAND, BOR, BXOR`. Since the [current mapping](https://github.com/pytorch/pytorch/blob/fc0cbf7dc77596dde642dd242bbb9c2bfab61bb7/torch/lib/c10d/ProcessGroupNCCL.cpp#L39) doesn't contain any of the mentioned bitwise operator, a default value of `ncclSum` is used instead. This PR should provide the expected behaviour where a runtime exception is thrown. # Notes - The way I'm throwing exceptions is derived from [ProcessGroupGloo.cpp](https://github.com/pytorch/pytorch/blob/fc0cbf7dc77596dde642dd242bbb9c2bfab61bb7/torch/lib/c10d/ProcessGroupGloo.cpp#L101) Pull Request resolved: pytorch#42669 Reviewed By: ezyang Differential Revision: D22996295 Pulled By: rohan-varma fbshipit-source-id: 83a9fedf11050d2890f9f05ebcedf53be0fc3516
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @rohan-varma
Fixes #41362 #39708
Description
NCCL doesn't support
BAND, BOR, BXOR. Since the current mapping doesn't contain any of the mentioned bitwise operator, a default value ofncclSumis used instead.This PR should provide the expected behaviour where a runtime exception is thrown.
Notes