Conversation
💊 CI failures summary and remediationsAs of commit 72466d2 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
|
cc @ptrblck |
|
@xwang233 I'll try to cherry-pick your fix there. |
|
@peterjc123 Thanks for checking the build! |
|
New error after cherry-picking your fix: See https://app.circleci.com/pipelines/github/pytorch/pytorch/195766/workflows/bc3ba331-dd46-4ec5-9356-02cdfa015561/jobs/6468496. |
This reverts commit 72d716e.
|
I have reverted the code in SparseCUDATensorMath.cu. |
|
The problem in #42406 will be fixed, since it crashes cuda11 + windows build. The change in You can check the table in the first post of this thread. |
For the latest build in the pr, it seems that it is supported. But yes, it's okay to bring them in with later commits. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| #if !defined(_MSC_VER) && defined(__CUDACC__) && CUSPARSE_VERSION >= 10301 // CUDA release >= 10.2 and not windows | ||
| #if defined(__CUDACC__) && CUSPARSE_VERSION >= 11000 |
There was a problem hiding this comment.
This would disable this feature on Linux with CUDA-10.2, isn't it?
There was a problem hiding this comment.
cuda 10.2 on linux will use the old API, which is still functionally the same
This fixes feature regression introduced by pytorch#42412 which limited all the use of the API to CUDA-11.0+
Fixes #42406
cusparse Xcsrmm2 API:
(#37202)
Before:
After:
cusparse bmm-sparse-dense API
reverted, will be revisited in the future
(cc @kurtamohler #33430)Before:
After: