Skip to content

Creates spectral ops test suite#42157

Closed
mruberry wants to merge 1 commit intomasterfrom
test_spectral_ops
Closed

Creates spectral ops test suite#42157
mruberry wants to merge 1 commit intomasterfrom
test_spectral_ops

Conversation

@mruberry
Copy link
Copy Markdown
Collaborator

In preparation for creating the new torch.fft namespace and NumPy-like fft functions, as well as supporting our goal of refactoring and reducing the size of test_torch.py, this PR creates a test suite for our spectral ops.

The existing spectral op tests from test_torch.py and test_cuda.py are moved to test_spectral_ops.py and updated to run under the device generic test framework.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jul 28, 2020

💊 CI failures summary and remediations

As of commit b7c82af (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 28 12:51:10 NameError: name 'log_handler' is not defined
Jul 28 12:51:09  
Jul 28 12:51:09 OK 
Jul 28 12:51:09  
Jul 28 12:51:09 Generating XML reports... 
Jul 28 12:51:09 Generated XML report: test-reports/dist-gloo/TEST-ForkTest-20200728125059.xml 
Jul 28 12:51:09 Generated XML report: test-reports/dist-gloo/TEST-SpawnTest-20200728125059.xml 
Jul 28 12:51:09 Running distributed/test_nccl ... [2020-07-28 12:51:09.567879] 
Jul 28 12:51:10 Traceback (most recent call last): 
Jul 28 12:51:10   File "distributed/test_nccl.py", line 26, in <module> 
Jul 28 12:51:10     log_handler.setStream(sys.stderr) 
Jul 28 12:51:10 NameError: name 'log_handler' is not defined 
Jul 28 12:51:10 Traceback (most recent call last): 
Jul 28 12:51:10   File "test/run_test.py", line 745, in <module> 
Jul 28 12:51:10     main() 
Jul 28 12:51:10   File "test/run_test.py", line 734, in main 
Jul 28 12:51:10     raise RuntimeError(err) 
Jul 28 12:51:10 RuntimeError: distributed/test_nccl failed! 
Jul 28 12:51:11 + cleanup 
Jul 28 12:51:11 + retcode=1 
Jul 28 12:51:11 + set +x 
Jul 28 12:51:11 =================== sccache compilation log =================== 

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 28 12:51:22 NameError: name 'log_handler' is not defined
Jul 28 12:51:21  
Jul 28 12:51:21 OK 
Jul 28 12:51:21  
Jul 28 12:51:21 Generating XML reports... 
Jul 28 12:51:21 Generated XML report: test-reports/dist-gloo/TEST-ForkTest-20200728125111.xml 
Jul 28 12:51:21 Generated XML report: test-reports/dist-gloo/TEST-SpawnTest-20200728125111.xml 
Jul 28 12:51:21 Running distributed/test_nccl ... [2020-07-28 12:51:21.294901] 
Jul 28 12:51:22 Traceback (most recent call last): 
Jul 28 12:51:22   File "distributed/test_nccl.py", line 26, in <module> 
Jul 28 12:51:22     log_handler.setStream(sys.stderr) 
Jul 28 12:51:22 NameError: name 'log_handler' is not defined 
Jul 28 12:51:22 Traceback (most recent call last): 
Jul 28 12:51:22   File "test/run_test.py", line 745, in <module> 
Jul 28 12:51:22     main() 
Jul 28 12:51:22   File "test/run_test.py", line 734, in main 
Jul 28 12:51:22     raise RuntimeError(err) 
Jul 28 12:51:22 RuntimeError: distributed/test_nccl failed! 
Jul 28 12:51:22 + cleanup 
Jul 28 12:51:22 + retcode=1 
Jul 28 12:51:22 + set +x 
Jul 28 12:51:22 =================== sccache compilation log =================== 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@mruberry mruberry mentioned this pull request Jul 28, 2020
37 tasks
@mruberry mruberry requested a review from gchanan July 28, 2020 17:15
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mruberry merged this pull request in 4b6e5f4.

@mruberry mruberry mentioned this pull request Aug 3, 2020
@mruberry mruberry deleted the test_spectral_ops branch August 21, 2020 19:30
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
In preparation for creating the new torch.fft namespace and NumPy-like fft functions, as well as supporting our goal of refactoring and reducing the size of test_torch.py, this PR creates a test suite for our spectral ops.

The existing spectral op tests from test_torch.py and test_cuda.py are moved to test_spectral_ops.py and updated to run under the device generic test framework.

Pull Request resolved: pytorch#42157

Reviewed By: albanD

Differential Revision: D22811096

Pulled By: mruberry

fbshipit-source-id: e5c50f0016ea6bb8b093cd6df2dbcef6db9bb6b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants