Skip to content

[ONNX] Export tensor#41872

Closed
shubhambhokare1 wants to merge 8 commits intopytorch:masterfrom
shubhambhokare1:sbhokare/tensor_symbolic
Closed

[ONNX] Export tensor#41872
shubhambhokare1 wants to merge 8 commits intopytorch:masterfrom
shubhambhokare1:sbhokare/tensor_symbolic

Conversation

@shubhambhokare1
Copy link
Copy Markdown
Collaborator

@shubhambhokare1 shubhambhokare1 commented Jul 22, 2020

Adding tensor symbolic for opset 9

@shubhambhokare1 shubhambhokare1 changed the title Sbhokare/tensor symbolic [ONNX] Export tensor Jul 22, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jul 23, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a9fe3f0 (more details on the Dr. CI page):

  • 5/5 failures possibly* introduced in this PR
    • 2/5 non-CircleCI failure(s)

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/binary_smoketest.py 
Auto-merging .circleci/cimodel/data/simple/binary_smoketest.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/binary_smoketest.py 
Auto-merging .circleci/cimodel/data/simple/binary_smoketest.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

See CircleCI build pytorch_macos_10_13_py3_test (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Aug 03 16:32:57 clang: error: linker command failed with exit code 1 (use -v to see invocation) 
Aug 03 16:32:57      
Aug 03 16:32:57     creating build/temp.macosx-10.9-x86_64-3.8/numba/cext 
Aug 03 16:32:57     compile options: '-I/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/include -I/Users/distiller/workspace/miniconda3/include/python3.8 -c' 
Aug 03 16:32:57     extra options: '-g' 
Aug 03 16:32:57     clang: numba/_helpermod.cclang: numba/cext/utils.c 
Aug 03 16:32:57     clang: numba/cext/dictobject.c 
Aug 03 16:32:57      
Aug 03 16:32:57     clang: numba/cext/listobject.c 
arch x86_64 -L/Users/distiller/workspace/miniconda3/lib -arch x86_64 -arch x86_64 build/temp.macosx-10.9-x86_64-3.8/numba/_helpermod.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/utils.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/dictobject.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/listobject.o -L/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib -lnpymath -o build/lib.macosx-10.9-x86_64-3.8/numba/_helperlib.cpython-38-darwin.so -headerpad_max_install_names 
Aug 03 16:32:57     ld: in /Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib/libnpymath.a(npy_math.o), could not parse object file /Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib/libnpymath.a(npy_math.o): 'Unknown attribute kind (61) (Producer: 'LLVM10.0.0' Reader: 'LLVM APPLE_1_902.0.39.2_0')', using libLTO version 'LLVM version 9.1.0, (clang-902.0.39.2)' for architecture x86_64 
Aug 03 16:32:57     clang: error: linker command failed with exit code 1 (use -v to see invocation) 
ler/workspace/miniconda3/lib -arch x86_64 -arch x86_64 build/temp.macosx-10.9-x86_64-3.8/numba/_helpermod.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/utils.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/dictobject.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/listobject.o -L/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib -lnpymath -o build/lib.macosx-10.9-x86_64-3.8/numba/_helperlib.cpython-38-darwin.so -headerpad_max_install_names" failed with exit status 1 
Aug 03 16:32:57     ---------------------------------------- 
d3j9r52rv80000gn/T/pip-install-u10z0ohf/numba/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/var/folders/gk/lkr9pm5x039fx6d3j9r52rv80000gn/T/pip-record-tp65ye1i/install-record.txt --single-version-externally-managed --compile --install-headers /Users/distiller/workspace/miniconda3/include/python3.8/numba Check the logs for full command output. 
Aug 03 16:32:57 + cleanup 
Aug 03 16:32:57 + retcode=1 
Aug 03 16:32:57 + set +x

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

KsenijaS
KsenijaS reviewed Jul 23, 2020
View reviewed changes
Comment thread torch/onnx/symbolic_opset9.py Outdated
@mrshenli mrshenli added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 23, 2020
neginraoof
neginraoof reviewed Jul 24, 2020
View reviewed changes
Comment thread test/onnx/test_pytorch_onnx_onnxruntime.py
neginraoof
neginraoof reviewed Jul 24, 2020
View reviewed changes
Comment thread torch/onnx/symbolic_opset9.py Outdated
neginraoof
neginraoof reviewed Jul 30, 2020
View reviewed changes
Comment thread torch/onnx/symbolic_opset9.py Outdated
neginraoof
neginraoof reviewed Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had a couple minor comments.
Thanks.

Comment thread torch/onnx/symbolic_opset9.py Outdated
Comment thread test/onnx/test_pytorch_onnx_onnxruntime.py
neginraoof
neginraoof approved these changes Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

facebook-github-bot
facebook-github-bot reviewed Aug 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 7, 2020

@bzinodev merged this pull request in 4959981.

@shubhambhokare1 shubhambhokare1 deleted the sbhokare/tensor_symbolic branch August 10, 2020 17:25
@spandantiwari spandantiwari mentioned this pull request Sep 2, 2020
Closed
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[ONNX] Export tensor (pytorch#41872)
f00843b 
Summary:
Adding tensor symbolic for opset 9

Pull Request resolved: pytorch#41872

Reviewed By: houseroad

Differential Revision: D22968426

Pulled By: bzinodev

fbshipit-source-id: 70e1afc7397e38039e2030e550fd72f09bac7c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@KsenijaS KsenijaS KsenijaS left review comments

@neginraoof neginraoof neginraoof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shubhambhokare1 @facebook-github-bot @KsenijaS @neginraoof @mrshenli @pytorchbot @mruberry