Skip to content

[pytorch] deprecate PYTORCH_DISABLE_TRACING macro#41004

Closed
ljk53 wants to merge 1 commit intogh/ljk53/155/basefrom
gh/ljk53/155/head
Closed

[pytorch] deprecate PYTORCH_DISABLE_TRACING macro#41004
ljk53 wants to merge 1 commit intogh/ljk53/155/basefrom
gh/ljk53/155/head

Conversation

@ljk53
Copy link
Copy Markdown
Contributor

@ljk53 ljk53 commented Jul 6, 2020 •
edited
Loading

Stack from ghstack:

Tracing has been moved into separate files. Now we can disable it by not compiling the source files for xplat mobile build.

Differential Revision: D22372615

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@ljk53
[pytorch] deprecate PYTORCH_DISABLE_TRACING macro
16da58f 
Tracing has been moved into separate files. Now we can disable it by not compiling the source files for xplat mobile build.

Differential Revision: [D22372615](https://our.internmc.facebook.com/intern/diff/D22372615/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22372615/)!

[ghstack-poisoned]
@ljk53 ljk53 requested review from albanD and apaszke as code owners July 6, 2020 08:37
@ljk53 ljk53 mentioned this pull request Jul 6, 2020
Closed
ljk53 added a commit that referenced this pull request Jul 6, 2020
@ljk53
[pytorch] deprecate PYTORCH_DISABLE_TRACING macro
ecad6b5 
Tracing has been moved into separate files. Now we can disable it by not compiling the source files for xplat mobile build.

Differential Revision: [D22372615](https://our.internmc.facebook.com/intern/diff/D22372615/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22372615/)!

ghstack-source-id: 107158627
Pull Request resolved: #41004
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jul 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 16da58f (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 06 09:11:45 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jul 06 09:11:45 processing existing schema:  __str__(__torch__.torch.classes._TorchScriptTesting._StackString _0) -> (str _0) 
Jul 06 09:11:45 processing existing schema:  __init__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jul 06 09:11:45 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int[] _0) 
Jul 06 09:11:45 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jul 06 09:11:45 processing existing schema:  top(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jul 06 09:11:45 processing existing schema:  pop(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jul 06 09:11:45 processing existing schema:  get(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, Tensor _1) -> (str _0) 
Jul 06 09:11:45 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0) -> (int _0) 
Jul 06 09:11:45 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, int _1) -> (None _0) 
Jul 06 09:11:45 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Jul 06 09:11:45 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Jul 06 09:11:45  
Jul 06 09:11:45 Broken ops: [ 
Jul 06 09:11:45 	aten::ne(str a, str b) -> (bool) 
Jul 06 09:11:45 	aten::eq(str a, str b) -> (bool) 
Jul 06 09:11:45 	aten::add(str a, str b) -> (str) 
Jul 06 09:11:45 ] 
Jul 06 09:11:45 =================== sccache compilation log =================== 
Jul 06 09:11:45 + cleanup 
Jul 06 09:11:45 + retcode=1 
Jul 06 09:11:45 + set +x
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 6, 2020

This pull request has been merged in 0fbd42b.

@facebook-github-bot facebook-github-bot deleted the gh/ljk53/155/head branch July 10, 2020 14:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@ljk53 @facebook-github-bot
[pytorch] deprecate PYTORCH_DISABLE_TRACING macro (pytorch#41004)
7ede71b 
Summary:
Pull Request resolved: pytorch#41004

Tracing has been moved into separate files. Now we can disable it by not compiling the source files for xplat mobile build.
ghstack-source-id: 107158627

Test Plan: CI + build size bot

Reviewed By: iseeyuan

Differential Revision: D22372615

fbshipit-source-id: bf2e2249e401295ff63020a292df119b188fb966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ljk53 @facebook-github-bot @mruberry