Skip to content

Check statstical diff rather than exact match for test_dropout_cuda.#40883

Closed
ailzhang wants to merge 2 commits intopytorch:masterfrom
ailzhang:fix_dropout_test
Closed

Check statstical diff rather than exact match for test_dropout_cuda.#40883
ailzhang wants to merge 2 commits intopytorch:masterfrom
ailzhang:fix_dropout_test

Conversation

@ailzhang
Copy link
Copy Markdown
Contributor

@ailzhang ailzhang commented Jul 1, 2020

There's is a TODO tracked in #40882

@ailzhang ailzhang requested review from Krovatkin and ngimel July 1, 2020 20:43
facebook-github-bot
facebook-github-bot reviewed Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jul 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 542880f (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

facebook-github-bot
facebook-github-bot reviewed Jul 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ailzhang ailzhang mentioned this pull request Jul 6, 2020
Merged
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 6, 2020

@ailzhang merged this pull request in e75f12a.

ailzhang pushed a commit to ailzhang/pytorch that referenced this pull request Jul 7, 2020
Patch pytorch#40883 to 1.6 release.
24bdc52
malfet pushed a commit that referenced this pull request Jul 9, 2020
@ailzhang
Patch #40883 to 1.6 release. (#41033)
c164fc4
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Check statstical diff rather than exact match for test_dropout_cuda. (p…
fcdf502 
…ytorch#40883)

Summary:
There's is a TODO tracked in pytorch#40882

Pull Request resolved: pytorch#40883

Reviewed By: pbelevich

Differential Revision: D22346087

Pulled By: ailzhang

fbshipit-source-id: b4789ca3a10f6a72c6e77276bde45633eb6cf545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ailzhang @facebook-github-bot @ngimel @mruberry