Skip to content

s/torch::jit::class_/torch::class_/#40795

Closed
jamesr66a wants to merge 1 commit intogh/jamesr66a/259/basefrom
gh/jamesr66a/259/head
Closed

s/torch::jit::class_/torch::class_/#40795
jamesr66a wants to merge 1 commit intogh/jamesr66a/259/basefrom
gh/jamesr66a/259/head

Conversation

@jamesr66a
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a commented Jun 30, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22314215

@jamesr66a jamesr66a requested a review from apaszke as a code owner June 30, 2020 18:04
jamesr66a pushed a commit that referenced this pull request Jun 30, 2020
s/torch::jit::class_/torch::class_/
0e48d35 
ghstack-source-id: a6b9c0d
Pull Request resolved: #40795
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 30, 2020
suo
suo approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BC?

@jamesr66a
Copy link
Copy Markdown
Collaborator Author

jamesr66a commented Jun 30, 2020

@suo the API itself was changed months ago, this is just changing callsites

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit f23bbfb (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_python_doc_push (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:43:17: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:37:37: error: 'png_const_bytep' was not declared in this scope 
Jun 30 18:42:52    reader.ptr = png_const_bytep(datap) + 8; 
Jun 30 18:42:52                                      ^ 
Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp: In lambda function: 
Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:42:27: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:42:52          std::copy(reader->ptr, reader->ptr + bytes, output); 
Jun 30 18:42:52                            ^ 
Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:42:40: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:42:52          std::copy(reader->ptr, reader->ptr + bytes, output); 
Jun 30 18:42:52                                         ^ 
Jun 30 18:42:52 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:43:17: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:42:52          reader->ptr += bytes; 
Jun 30 18:42:52                  ^ 
Jun 30 18:42:52 error: command 'gcc' failed with exit status 1
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 7, 2020

@jamesr66a merged this pull request in c0f9bf9.

csarofeen pushed a commit to csarofeen/pytorch that referenced this pull request Jul 7, 2020
@csarofeen
s/torch::jit::class_/torch::class_/ (pytorch#40795)
21a7178 
Summary: Pull Request resolved: pytorch#40795

Test Plan: Imported from OSS

Reviewed By: suo

Differential Revision: D22314215

Pulled By: jamesr66a

fbshipit-source-id: a2fb5c6804d4014f8e437c6858a7be8cd3efb380
@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/259/head branch July 10, 2020 14:18
csarofeen added a commit to csarofeen/pytorch that referenced this pull request Aug 16, 2020
@csarofeen
Revert "s/torch::jit::class_/torch::class_/ (pytorch#40795)"
8e7073a 
This reverts commit 21a7178.
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
s/torch::jit::class_/torch::class_/ (pytorch#40795)
25eb145 
Summary: Pull Request resolved: pytorch#40795

Test Plan: Imported from OSS

Reviewed By: suo

Differential Revision: D22314215

Pulled By: jamesr66a

fbshipit-source-id: a2fb5c6804d4014f8e437c6858a7be8cd3efb380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesr66a @facebook-github-bot @suo @mruberry