Skip to content

Change to.dtype_layout to c10-full#40714

Closed
smessmer wants to merge 5 commits intogh/smessmer/235/basefrom
gh/smessmer/235/head
Closed

Change to.dtype_layout to c10-full#40714
smessmer wants to merge 5 commits intogh/smessmer/235/basefrom
gh/smessmer/235/head

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Jun 29, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22289257

@smessmer smessmer mentioned this pull request Jun 29, 2020
Closed
smessmer added a commit that referenced this pull request Jun 29, 2020
@smessmer
Change to.dtype_layout to c10-full
a08ba6c 
-

Differential Revision: [D22289257](https://our.internmc.facebook.com/intern/diff/D22289257/)

ghstack-source-id: 106797948
Pull Request resolved: #40714
@dr-ci
Copy link

dr-ci bot commented Jun 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fd7e22c (more details on the Dr. CI page):

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

[ FAILED ] TensorTest.FromBlob 
 
[----------] 1 test from ParallelTest 
[ RUN      ] ParallelTest.DataParallelUsesAllAvailableCUDADevices_CUDA 
[       OK ] ParallelTest.DataParallelUsesAllAvailableCUDADevices_CUDA (0 ms) 
[----------] 1 test from ParallelTest (0 ms total) 
 
[----------] Global test environment tear-down 
[==========] 877 tests from 38 test cases ran. (68779 ms total) 
[  PASSED  ] 876 tests. 
[  FAILED  ] 1 test, listed below: 
[  FAILED  ] TensorTest.FromBlob 
 
 1 FAILED TEST 
+ cleanup
+ retcode=1
+ set +x

See CircleCI build pytorch_linux_backward_compatibility_check_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 08 21:01:46 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jul 08 21:01:46 processing existing schema:  __str__(__torch__.torch.classes._TorchScriptTesting._StackString _0) -> (str _0) 
Jul 08 21:01:46 processing existing schema:  __init__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jul 08 21:01:46 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int[] _0) 
Jul 08 21:01:46 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jul 08 21:01:46 processing existing schema:  top(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jul 08 21:01:46 processing existing schema:  pop(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jul 08 21:01:46 processing existing schema:  get(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, Tensor _1) -> (str _0) 
Jul 08 21:01:46 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0) -> (int _0) 
Jul 08 21:01:46 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, int _1) -> (None _0) 
Jul 08 21:01:46 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Jul 08 21:01:46 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Jul 08 21:01:46  
Jul 08 21:01:46 Broken ops: [ 
Jul 08 21:01:46 	aten::to.dtype_layout(Tensor self, *, int dtype, int layout, Device device, bool pin_memory=False, bool non_blocking=False, bool copy=False, int? memory_format=None) -> (Tensor) 
Jul 08 21:01:46 ] 
Jul 08 21:01:46 + cleanup 
Jul 08 21:01:46 + retcode=1 
Jul 08 21:01:46 + set +x 
Jul 08 21:01:46 =================== sccache compilation log =================== 
Jul 08 21:01:46 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jul 08 21:01:46 Compile requests                 0

❄️ 7 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 22:00:58 unknown file: Failure 
Jul 08 22:00:58 [       OK ] TensorTest.TorchTensorCtorWithoutSpecifyingDtype (1 ms) 
Jul 08 22:00:58 [ RUN      ] TensorTest.TorchTensorCtorWithNonDtypeOptions 
Jul 08 22:00:58 [       OK ] TensorTest.TorchTensorCtorWithNonDtypeOptions (0 ms) 
Jul 08 22:00:58 [ RUN      ] TensorTest.Arange 
Jul 08 22:00:58 [       OK ] TensorTest.Arange (0 ms) 
Jul 08 22:00:58 [ RUN      ] TensorTest.PrettyPrintTensorDataContainer 
Jul 08 22:00:58 [       OK ] TensorTest.PrettyPrintTensorDataContainer (0 ms) 
Jul 08 22:00:58 [ RUN      ] TensorTest.TensorDataContainerCallingAccessorOfWrongType 
Jul 08 22:00:58 [       OK ] TensorTest.TensorDataContainerCallingAccessorOfWrongType (9 ms) 
Jul 08 22:00:58 [ RUN      ] TensorTest.FromBlob 
Jul 08 22:00:58 unknown file: Failure 
Jul 08 22:00:58 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 22:00:58 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:20 (most recent call first): 
Jul 08 22:00:58 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x69 (0x7ffaaa4b9989 in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 22:00:58 frame #1: <unknown function> + 0x1423337 (0x7ffaabaf7337 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 22:00:58 frame #2: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0x74 (0x7ffaabc25e04 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 22:00:58 frame #3: build/bin/test_api() [0x796c42] 
Jul 08 22:00:58 frame #4: TensorTest_FromBlob_Test::TestBody() + 0x10b (0xbb3f2b in build/bin/test_api) 
Jul 08 22:00:58 frame #5: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x43 (0xbfe303 in build/bin/test_api) 
Jul 08 22:00:58 frame #6: build/bin/test_api() [0xbf483b] 
Jul 08 22:00:58 frame #7: build/bin/test_api() [0xbf4b75]

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (2/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 21:59:49 unknown file: Failure 
Jul 08 21:59:49 [       OK ] TensorTest.TorchTensorCtorWithoutSpecifyingDtype (0 ms) 
Jul 08 21:59:49 [ RUN      ] TensorTest.TorchTensorCtorWithNonDtypeOptions 
Jul 08 21:59:49 [       OK ] TensorTest.TorchTensorCtorWithNonDtypeOptions (0 ms) 
Jul 08 21:59:49 [ RUN      ] TensorTest.Arange 
Jul 08 21:59:49 [       OK ] TensorTest.Arange (0 ms) 
Jul 08 21:59:49 [ RUN      ] TensorTest.PrettyPrintTensorDataContainer 
Jul 08 21:59:49 [       OK ] TensorTest.PrettyPrintTensorDataContainer (0 ms) 
Jul 08 21:59:49 [ RUN      ] TensorTest.TensorDataContainerCallingAccessorOfWrongType 
Jul 08 21:59:49 [       OK ] TensorTest.TensorDataContainerCallingAccessorOfWrongType (9 ms) 
Jul 08 21:59:49 [ RUN      ] TensorTest.FromBlob 
Jul 08 21:59:49 unknown file: Failure 
Jul 08 21:59:49 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 21:59:49 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:20 (most recent call first): 
Jul 08 21:59:49 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x69 (0x7fe72e215989 in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 21:59:49 frame #1: <unknown function> + 0x1423337 (0x7fe72f853337 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:59:49 frame #2: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0x74 (0x7fe72f981e04 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:59:49 frame #3: build/bin/test_api() [0x796c42] 
Jul 08 21:59:49 frame #4: TensorTest_FromBlob_Test::TestBody() + 0x10b (0xbb3f2b in build/bin/test_api) 
Jul 08 21:59:49 frame #5: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x43 (0xbfe303 in build/bin/test_api) 
Jul 08 21:59:49 frame #6: build/bin/test_api() [0xbf483b] 
Jul 08 21:59:49 frame #7: build/bin/test_api() [0xbf4b75]

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_test (3/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 21:49:00 unknown file: Failure 
Jul 08 21:49:00 [       OK ] TensorTest.TorchTensorCtorWithoutSpecifyingDtype (0 ms) 
Jul 08 21:49:00 [ RUN      ] TensorTest.TorchTensorCtorWithNonDtypeOptions 
Jul 08 21:49:00 [       OK ] TensorTest.TorchTensorCtorWithNonDtypeOptions (1 ms) 
Jul 08 21:49:00 [ RUN      ] TensorTest.Arange 
Jul 08 21:49:00 [       OK ] TensorTest.Arange (0 ms) 
Jul 08 21:49:00 [ RUN      ] TensorTest.PrettyPrintTensorDataContainer 
Jul 08 21:49:00 [       OK ] TensorTest.PrettyPrintTensorDataContainer (0 ms) 
Jul 08 21:49:00 [ RUN      ] TensorTest.TensorDataContainerCallingAccessorOfWrongType 
Jul 08 21:49:00 [       OK ] TensorTest.TensorDataContainerCallingAccessorOfWrongType (8 ms) 
Jul 08 21:49:00 [ RUN      ] TensorTest.FromBlob 
Jul 08 21:49:00 unknown file: Failure 
Jul 08 21:49:00 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 21:49:00 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:18 (most recent call first): 
Jul 08 21:49:00 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x68 (0x7f1fd881c408 in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 21:49:00 frame #1: <unknown function> + 0x1b59afc (0x7f1fda590afc in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:49:00 frame #2: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0x6e (0x7f1fda6b1b6e in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:49:00 frame #3: <unknown function> + 0x4c5e92 (0x564774a24e92 in build/bin/test_api) 
Jul 08 21:49:00 frame #4: TensorTest_FromBlob_Test::TestBody() + 0x14f (0x564774dddd1f in build/bin/test_api) 
Jul 08 21:49:00 frame #5: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4d (0x564774e27f2d in build/bin/test_api) 
Jul 08 21:49:00 frame #6: <unknown function> + 0x8be16d (0x564774e1d16d in build/bin/test_api) 
Jul 08 21:49:00 frame #7: <unknown function> + 0x8be61d (0x564774e1d61d in build/bin/test_api)

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (4/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 22:51:58 unknown file: Failure 
Jul 08 22:51:55 [       OK ] BasicTest.BasicTestCPU (3771 ms) 
Jul 08 22:51:55 [ RUN      ] BasicTest.BasicTestHalfCPU 
Jul 08 22:51:55    125 ms 
Jul 08 22:51:55    237 ms 
Jul 08 22:51:55 [       OK ] BasicTest.BasicTestHalfCPU (378 ms) 
Jul 08 22:51:55 [ RUN      ] BasicTest.BasicTestCUDA 
Jul 08 22:51:57    619 ms 
Jul 08 22:51:58    824 ms 
Jul 08 22:51:58 [       OK ] BasicTest.BasicTestCUDA (2850 ms) 
Jul 08 22:51:58 [ RUN      ] BasicTest.FactoryMethodsTest 
Jul 08 22:51:58 unknown file: Failure 
Jul 08 22:51:58 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 22:51:58 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:20 (most recent call first): 
Jul 08 22:51:58 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7f94ea7856fb in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 22:51:58 frame #1: <unknown function> + 0x13d3d66 (0x7f94f6b8ed66 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 22:51:58 frame #2: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0x70 (0x7f94f6cccb60 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 22:51:58 frame #3: BasicTest_FactoryMethodsTest_Test::TestBody() + 0x1784 (0x4224a4 in ./basic) 
Jul 08 22:51:58 frame #4: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0x45422a in ./basic) 
Jul 08 22:51:58 frame #5: ./basic() [0x449dc6] 
Jul 08 22:51:58 frame #6: ./basic() [0x44a3b5] 
Jul 08 22:51:58 frame #7: ./basic() [0x44a655]

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (5/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 21:46:49 unknown file: Failure 
Jul 08 21:46:49 [       OK ] TensorTest.TorchTensorCtorWithoutSpecifyingDtype (0 ms) 
Jul 08 21:46:49 [ RUN      ] TensorTest.TorchTensorCtorWithNonDtypeOptions 
Jul 08 21:46:49 [       OK ] TensorTest.TorchTensorCtorWithNonDtypeOptions (0 ms) 
Jul 08 21:46:49 [ RUN      ] TensorTest.Arange 
Jul 08 21:46:49 [       OK ] TensorTest.Arange (0 ms) 
Jul 08 21:46:49 [ RUN      ] TensorTest.PrettyPrintTensorDataContainer 
Jul 08 21:46:49 [       OK ] TensorTest.PrettyPrintTensorDataContainer (1 ms) 
Jul 08 21:46:49 [ RUN      ] TensorTest.TensorDataContainerCallingAccessorOfWrongType 
Jul 08 21:46:49 [       OK ] TensorTest.TensorDataContainerCallingAccessorOfWrongType (7 ms) 
Jul 08 21:46:49 [ RUN      ] TensorTest.FromBlob 
Jul 08 21:46:49 unknown file: Failure 
Jul 08 21:46:49 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 21:46:49 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:20 (most recent call first): 
Jul 08 21:46:49 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x7d (0x7f80118e35dd in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 21:46:49 frame #1: <unknown function> + 0x15103db (0x7f801300f3db in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:46:49 frame #2: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0xc9 (0x7f80130c9d89 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 21:46:49 frame #3: build/bin/test_api() [0x8b62db] 
Jul 08 21:46:49 frame #4: build/bin/test_api() [0x8b606c] 
Jul 08 21:46:49 frame #5: build/bin/test_api() [0x8b5e74] 
Jul 08 21:46:49 frame #6: TensorTest_FromBlob_Test::TestBody() + 0x97 (0xff72b7 in build/bin/test_api) 
Jul 08 21:46:49 frame #7: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x44 (0x1036454 in build/bin/test_api)

See CircleCI build pytorch_bazel_test (6/7)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

gpg: no valid OpenPGP data found. 
+ curl -s -L --retry 3 https://nvidia.github.io/nvidia-docker/gpgkey 
+ sudo apt-key add - 
gpg: no valid OpenPGP data found.

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test (7/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 08 23:17:11 unknown file: Failure 
Jul 08 23:17:11 [       OK ] TensorTest.TorchTensorCtorWithoutSpecifyingDtype (1 ms) 
Jul 08 23:17:11 [ RUN      ] TensorTest.TorchTensorCtorWithNonDtypeOptions 
Jul 08 23:17:11 [       OK ] TensorTest.TorchTensorCtorWithNonDtypeOptions (1 ms) 
Jul 08 23:17:11 [ RUN      ] TensorTest.Arange 
Jul 08 23:17:11 [       OK ] TensorTest.Arange (0 ms) 
Jul 08 23:17:11 [ RUN      ] TensorTest.PrettyPrintTensorDataContainer 
Jul 08 23:17:11 [       OK ] TensorTest.PrettyPrintTensorDataContainer (1 ms) 
Jul 08 23:17:11 [ RUN      ] TensorTest.TensorDataContainerCallingAccessorOfWrongType 
Jul 08 23:17:11 [       OK ] TensorTest.TensorDataContainerCallingAccessorOfWrongType (16 ms) 
Jul 08 23:17:11 [ RUN      ] TensorTest.FromBlob 
Jul 08 23:17:11 unknown file: Failure 
Jul 08 23:17:11 C++ exception with description "Operators taking TensorOptions cannot take a TensorOptions with options.requires_grad set as 1 
Jul 08 23:17:11 Exception raised from process_memory_format at /var/lib/jenkins/workspace/aten/src/ATen/core/op_registration/hacky_wrapper_for_legacy_signatures.h:20 (most recent call first): 
Jul 08 23:17:11 frame #0: <unknown function> + 0x14bd73 (0x7fe7418a7d73 in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 23:17:11 frame #1: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x1eb (0x7fe7418a62db in /var/lib/jenkins/workspace/build/lib/libc10.so) 
Jul 08 23:17:11 frame #2: <unknown function> + 0xbe86dd1 (0x7fe74da23dd1 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 23:17:11 frame #3: at::empty(c10::ArrayRef<long>, c10::TensorOptions const&, c10::optional<c10::MemoryFormat>) + 0x225 (0x7fe74dc23ae5 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so) 
Jul 08 23:17:11 frame #4: <unknown function> + 0x1053765 (0x55760f9de765 in build/bin/test_api) 
Jul 08 23:17:11 frame #5: <unknown function> + 0x1052dc7 (0x55760f9dddc7 in build/bin/test_api) 
Jul 08 23:17:11 frame #6: <unknown function> + 0x10529a1 (0x55760f9dd9a1 in build/bin/test_api) 
Jul 08 23:17:11 frame #7: TensorTest_FromBlob_Test::TestBody() + 0x5a4 (0x5576103e3484 in build/bin/test_api)

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 30 times.

smessmer added a commit that referenced this pull request Jul 8, 2020
@smessmer
Change to.dtype_layout to c10-full
7da869a 
Pull Request resolved: #40714

-
ghstack-source-id: 107330185

Differential Revision: [D22289257](https://our.internmc.facebook.com/intern/diff/D22289257/)
smessmer added a commit that referenced this pull request Jul 8, 2020
@smessmer
Change to.dtype_layout to c10-full
f9a3183 
Pull Request resolved: #40714

-
ghstack-source-id: 107372381

Differential Revision: [D22289257](https://our.internmc.facebook.com/intern/diff/D22289257/)
@smessmer smessmer closed this Jul 8, 2020
@facebook-github-bot facebook-github-bot deleted the gh/smessmer/235/head branch August 8, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smessmer