Skip to content

Remove constexpr for NVCC on Windows (v1.6)#40676

Merged
malfet merged 1 commit intopytorch:release/1.6from
peterjc123:constexpr_nvcc_windows_1.6
Jun 29, 2020
Merged

Remove constexpr for NVCC on Windows (v1.6)#40676
malfet merged 1 commit intopytorch:release/1.6from
peterjc123:constexpr_nvcc_windows_1.6

Conversation

@peterjc123
Copy link
Copy Markdown
Collaborator

@peterjc123 peterjc123 commented Jun 28, 2020 •
edited
Loading

#40675 for v1.6

@peterjc123 peterjc123 requested a review from apaszke as a code owner June 28, 2020 06:04
@peterjc123 peterjc123 linked an issue Jun 28, 2020 that may be closed by this pull request
member "torch::jit::detail::AttributePolicy::all_slots" may not be initialized #39394
Closed
@peterjc123 peterjc123 changed the title Remove constexpr for NVCC on Windows Remove constexpr for NVCC on Windows (v1.6) Jun 28, 2020
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 28, 2020
@peterjc123 peterjc123 mentioned this pull request Jun 28, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci bot commented Jun 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit df44370 (more details on the Dr. CI page):

  • 6/6 failures introduced in this PR

🕵️ 6 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_profiling_test (1/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:34:31 caused by: Connection refused (os error 111) 
Jun 28 06:34:31 ++++ extract_trap_cmd 
Jun 28 06:34:31 ++++ printf '%s\n' '' 
Jun 28 06:34:31 +++ printf '%s\n' cleanup 
Jun 28 06:34:31 ++ trap -- ' 
Jun 28 06:34:31 cleanup' EXIT 
Jun 28 06:34:31 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-ge_config_profiling-test != *pytorch-win-* ]] 
Jun 28 06:34:31 ++ which sccache 
Jun 28 06:34:31 ++ sccache --stop-server 
Jun 28 06:34:31 Stopping sccache server... 
Jun 28 06:34:31 error: couldn't connect to server 
Jun 28 06:34:31 caused by: Connection refused (os error 111) 
Jun 28 06:34:31 ++ true 
Jun 28 06:34:31 ++ rm /var/lib/jenkins/sccache_error.log 
Jun 28 06:34:31 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Jun 28 06:34:31 ++ SCCACHE_IDLE_TIMEOUT=1200 
Jun 28 06:34:31 ++ RUST_LOG=sccache::server=error 
Jun 28 06:34:31 ++ sccache --start-server 
Jun 28 06:34:31 Starting sccache server... 
Jun 28 06:34:31 ++ sccache --zero-stats 
Jun 28 06:34:31 Compile requests                 0 
Jun 28 06:34:31 Compile requests executed        0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (2/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:34:08 caused by: Connection refused (os error 111) 
Jun 28 06:34:08 ++++ extract_trap_cmd 
Jun 28 06:34:08 ++++ printf '%s\n' '' 
Jun 28 06:34:08 +++ printf '%s\n' cleanup 
Jun 28 06:34:08 ++ trap -- ' 
Jun 28 06:34:08 cleanup' EXIT 
Jun 28 06:34:08 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-ge_config_simple-test != *pytorch-win-* ]] 
Jun 28 06:34:08 ++ which sccache 
Jun 28 06:34:08 ++ sccache --stop-server 
Jun 28 06:34:08 Stopping sccache server... 
Jun 28 06:34:08 error: couldn't connect to server 
Jun 28 06:34:08 caused by: Connection refused (os error 111) 
Jun 28 06:34:08 ++ true 
Jun 28 06:34:08 ++ rm /var/lib/jenkins/sccache_error.log 
Jun 28 06:34:08 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Jun 28 06:34:08 ++ SCCACHE_IDLE_TIMEOUT=1200 
Jun 28 06:34:08 ++ RUST_LOG=sccache::server=error 
Jun 28 06:34:08 ++ sccache --start-server 
Jun 28 06:34:08 Starting sccache server... 
Jun 28 06:34:08 ++ sccache --zero-stats 
Jun 28 06:34:08 Compile requests                 0 
Jun 28 06:34:08 Compile requests executed        0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (3/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:34:34 caused by: Connection refused (os error 111) 
Jun 28 06:34:34 ++++ extract_trap_cmd 
Jun 28 06:34:34 ++++ printf '%s\n' '' 
Jun 28 06:34:34 +++ printf '%s\n' cleanup 
Jun 28 06:34:34 ++ trap -- ' 
Jun 28 06:34:34 cleanup' EXIT 
Jun 28 06:34:34 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test != *pytorch-win-* ]] 
Jun 28 06:34:34 ++ which sccache 
Jun 28 06:34:34 ++ sccache --stop-server 
Jun 28 06:34:34 Stopping sccache server... 
Jun 28 06:34:34 error: couldn't connect to server 
Jun 28 06:34:34 caused by: Connection refused (os error 111) 
Jun 28 06:34:34 ++ true 
Jun 28 06:34:34 ++ rm /var/lib/jenkins/sccache_error.log 
Jun 28 06:34:34 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Jun 28 06:34:34 ++ SCCACHE_IDLE_TIMEOUT=1200 
Jun 28 06:34:34 ++ RUST_LOG=sccache::server=error 
Jun 28 06:34:34 ++ sccache --start-server 
Jun 28 06:34:34 Starting sccache server... 
Jun 28 06:34:34 ++ sccache --zero-stats 
Jun 28 06:34:34 Compile requests                 0 
Jun 28 06:34:34 Compile requests executed        0

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (4/6)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:21:22 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n return ((int*)(&strtod_l))[argc];\n ^\n1 error generated.\n" } 
Jun 28 06:21:21     assert check_overrides(overrides, overridden) 
Jun 28 06:21:21 AssertionError 
Jun 28 06:21:21 Building torch_xla version: 1.6 
Jun 28 06:21:21 XLA Commit ID: 0273128bff6636217d406157e29debee7546a0b2 
Jun 28 06:21:21 PyTorch Commit ID: df44370f9baf18384aca60bade6125f9c3077fd9 
Jun 28 06:21:21 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Jun 28 06:21:22 + cleanup 
Jun 28 06:21:22 + retcode=1 
Jun 28 06:21:22 + set +x 
Jun 28 06:21:22 =================== sccache compilation log =================== 
Jun 28 06:21:22 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n  return ((int*)(&strtod_l))[argc];\n                  ^\n1 error generated.\n" } 
Jun 28 06:21:22  
Jun 28 06:21:22 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jun 28 06:21:22 Compile requests              5988 
Jun 28 06:21:22 Compile requests executed     3552 
Jun 28 06:21:22 Cache hits                    3536 
Jun 28 06:21:22 Cache misses                     0 
Jun 28 06:21:22 Cache timeouts                   0 
Jun 28 06:21:22 Cache read errors                0 
Jun 28 06:21:22 Forced recaches                  0 
Jun 28 06:21:22 Cache write errors               0

See CircleCI build pytorch_linux_backward_compatibility_check_test (5/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:35:04 caused by: Connection refused (os error 111) 
Jun 28 06:35:04 ++++ extract_trap_cmd 
Jun 28 06:35:04 ++++ printf '%s\n' '' 
Jun 28 06:35:04 +++ printf '%s\n' cleanup 
Jun 28 06:35:04 ++ trap -- ' 
Jun 28 06:35:04 cleanup' EXIT 
Jun 28 06:35:04 ++ [[ pytorch-linux-backward-compatibility-check-test != *pytorch-win-* ]] 
Jun 28 06:35:04 ++ which sccache 
Jun 28 06:35:04 ++ sccache --stop-server 
Jun 28 06:35:04 Stopping sccache server... 
Jun 28 06:35:04 error: couldn't connect to server 
Jun 28 06:35:04 caused by: Connection refused (os error 111) 
Jun 28 06:35:04 ++ true 
Jun 28 06:35:04 ++ rm /var/lib/jenkins/sccache_error.log 
Jun 28 06:35:04 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Jun 28 06:35:04 ++ SCCACHE_IDLE_TIMEOUT=1200 
Jun 28 06:35:04 ++ RUST_LOG=sccache::server=error 
Jun 28 06:35:04 ++ sccache --start-server 
Jun 28 06:35:04 Starting sccache server... 
Jun 28 06:35:04 ++ sccache --zero-stats 
Jun 28 06:35:04 Compile requests                 0 
Jun 28 06:35:04 Compile requests executed        0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_legacy_test (6/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 28 06:34:24 caused by: Connection refused (os error 111) 
Jun 28 06:34:24 ++++ extract_trap_cmd 
Jun 28 06:34:24 ++++ printf '%s\n' '' 
Jun 28 06:34:24 +++ printf '%s\n' cleanup 
Jun 28 06:34:24 ++ trap -- ' 
Jun 28 06:34:24 cleanup' EXIT 
Jun 28 06:34:24 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-ge_config_legacy-test != *pytorch-win-* ]] 
Jun 28 06:34:24 ++ which sccache 
Jun 28 06:34:24 ++ sccache --stop-server 
Jun 28 06:34:24 Stopping sccache server... 
Jun 28 06:34:24 error: couldn't connect to server 
Jun 28 06:34:24 caused by: Connection refused (os error 111) 
Jun 28 06:34:24 ++ true 
Jun 28 06:34:24 ++ rm /var/lib/jenkins/sccache_error.log 
Jun 28 06:34:24 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Jun 28 06:34:24 ++ SCCACHE_IDLE_TIMEOUT=1200 
Jun 28 06:34:24 ++ RUST_LOG=sccache::server=error 
Jun 28 06:34:24 ++ sccache --start-server 
Jun 28 06:34:24 Starting sccache server... 
Jun 28 06:34:24 ++ sccache --zero-stats 
Jun 28 06:34:24 Compile requests                 0 
Jun 28 06:34:24 Compile requests executed        0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@malfet malfet merged commit ea1b0db into pytorch:release/1.6 Jun 29, 2020
@peterjc123 peterjc123 mentioned this pull request Jun 30, 2020
Closed
@peterjc123 peterjc123 deleted the constexpr_nvcc_windows_1.6 branch July 1, 2020 03:35
@datumbox datumbox mentioned this pull request Dec 2, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

member "torch::jit::detail::AttributePolicy::all_slots" may not be initialized

4 participants

@peterjc123 @malfet @facebook-github-bot @pytorchbot