Remove constexpr for NVCC on Windows#40675
Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
ezyang
approved these changes
Jun 29, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
malfet
approved these changes
Jun 29, 2020
Contributor
Contributor
1 similar comment
Contributor
Contributor
|
nvcc + |
This was referenced Jul 31, 2020
bdhirsh
added a commit
that referenced
this pull request
Jun 17, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 18, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 21, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 21, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Reland of #59115, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 22, 2021
Reland of #59115, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 24, 2021
Reland of #59115, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 24, 2021
Pull Request resolved: #60214 Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29213932/)! ghstack-source-id: 132130129
bdhirsh
added a commit
that referenced
this pull request
Jun 24, 2021
… API"" Reland of #59115, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 24, 2021
Reland of #59115, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_CONST_EXCEPT_WIN_CUDA` (had to make a new macro that was a slight adjustment to an existing one) This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Jun 24, 2021
Pull Request resolved: #60214 Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Differential Revision: [D29213932](https://our.internmc.facebook.com/intern/diff/D29213932/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29213932/)! ghstack-source-id: 132300710
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
Summary: Pull Request resolved: #60214 Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D29213932 Pulled By: bdhirsh fbshipit-source-id: b90c7c10e5a51f8d6173ddca673b418e5774c248
asuhan
pushed a commit
to asuhan/pytorch
that referenced
this pull request
Jun 28, 2021
Summary: Pull Request resolved: pytorch#60214 Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: pytorch#40675 This reverts commit 6d0fb85. Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D29213932 Pulled By: bdhirsh fbshipit-source-id: b90c7c10e5a51f8d6173ddca673b418e5774c248
asuhan
pushed a commit
that referenced
this pull request
Jun 30, 2021
Summary: Pull Request resolved: #60214 Relanding this PR, but with a fix for windows cuda builds (example failure in master here: https://github.com/pytorch/pytorch/runs/2852662871) This is identical to the original PR except for one change in `tools/codegen/gen.py`: `static constexpr` -> `static CONSTEXPR_EXCEPT_WIN_CUDA` This actually took a while to figure out, until I tracked down a previous pytorch PR that encountered a similar issue: #40675 This reverts commit 6d0fb85. Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D29213932 Pulled By: bdhirsh fbshipit-source-id: b90c7c10e5a51f8d6173ddca673b418e5774c248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are not well supported. Fixes #40393 and #39394.