[JIT] Remove dead store in unpickler.cpp#40625
Closed
SplitInfinity wants to merge 1 commit intopytorch:masterfrom
Closed
[JIT] Remove dead store in unpickler.cpp#40625SplitInfinity wants to merge 1 commit intopytorch:masterfrom
SplitInfinity wants to merge 1 commit intopytorch:masterfrom
Conversation
7089fce to
3ba5232
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22259289 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22259289 |
3ba5232 to
7bb748f
Compare
💊 CI failures summary and remediationsAs of commit a97f3c7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
suo
requested changes
Jun 26, 2020
Member
suo
left a comment
There was a problem hiding this comment.
looks like MSVC wants that variable?
Author
|
No, I got too trigger happy - the dead store is |
Summary: Pull Request resolved: pytorch#40625 Test Plan: Continuous integration. Differential Revision: D22259289 fbshipit-source-id: 7304688af8b9aa277c7ce672118cfa0f655ec11d
7bb748f to
a97f3c7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22259289 |
suo
approved these changes
Jul 1, 2020
Contributor
|
This pull request has been merged in e026d91. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#40625 Test Plan: Continuous integration. Reviewed By: suo Differential Revision: D22259289 fbshipit-source-id: 76cb097dd06a636004fc780b17cb20f27d3821de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: Continuous integration.
Differential Revision: D22259289