Skip to content

Assert MKL ld* conditions for ger, gemm, and gemv#4056

Merged
soumith merged 1 commit intopytorch:masterfrom
ssnl:assert_mkl
Dec 18, 2017
Merged

Assert MKL ld* conditions for ger, gemm, and gemv#4056
soumith merged 1 commit intopytorch:masterfrom
ssnl:assert_mkl

Conversation

@ssnl
Copy link
Copy Markdown
Collaborator

@ssnl ssnl commented Dec 6, 2017

Issue #3606 .

Changes are mainly:

  1. in THBlas.c, use assert rather than if.
  2. in relevant caller functions in THTensorMath.c, make tensors contiguous if those checks aren't met.
  3. add contiguity checks in 4 legacy kernels ([Spatial|Volumetric](Full)?DilatedConvolution) that calls these methods. They are contiguous before, but the logic involves both Python and C++, and is a bit complicated, so I add the check to be clear, and to be safe.

@soumith soumith merged commit 3796ce9 into pytorch:master Dec 18, 2017
@ssnl ssnl deleted the assert_mkl branch December 18, 2017 16:22
@soumith soumith added the 0.3.1 label Feb 4, 2018
soumith pushed a commit that referenced this pull request Feb 7, 2018
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants