Skip to content

Add missing file to BUILD.bazel#40536

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-bazel-regression
Closed

Add missing file to BUILD.bazel#40536
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-bazel-regression

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Jun 24, 2020

Add int8_gen_quant_params.cc added by
#40494 to bazel build rules

@malfet
Add missing file to BUILD.bazel
06b080d 
Add `int8_gen_quant_params.cc` added by
pytorch#40494 to bazel build rules
zhaojuanmao
zhaojuanmao approved these changes Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhaojuanmao zhaojuanmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it!

csummersea
csummersea approved these changes Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@csummersea csummersea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

facebook-github-bot
facebook-github-bot reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 06b080d (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

facebook-github-bot
facebook-github-bot reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yns88 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet deleted the malfet/fix-bazel-regression branch June 25, 2020 04:15
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 25, 2020

@malfet merged this pull request in e12f73e.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@malfet @facebook-github-bot
Add missing file to BUILD.bazel (pytorch#40536)
739ba2b 
Summary:
Add `int8_gen_quant_params.cc` added by
pytorch#40494 to bazel build rules
Pull Request resolved: pytorch#40536

Reviewed By: mruberry

Differential Revision: D22219595

Pulled By: malfet

fbshipit-source-id: 2875a0b9c55bad2b052a898661b96eab490f6451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaojuanmao zhaojuanmao zhaojuanmao approved these changes

@seemethere seemethere Awaiting requested review from seemethere

@yns88 yns88 Awaiting requested review from yns88

+2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@csummersea csummersea csummersea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @csummersea @zhaojuanmao @mruberry