Skip to content

Update FP16 to FP16:4dfe081cf6bcd15db339cf2680b9281b8451eeb3.#40526

Closed
AshkanAliabadi wants to merge 1 commit intopytorch:masterfrom
AshkanAliabadi:fp16
Closed

Update FP16 to FP16:4dfe081cf6bcd15db339cf2680b9281b8451eeb3.#40526
AshkanAliabadi wants to merge 1 commit intopytorch:masterfrom
AshkanAliabadi:fp16

Conversation

@AshkanAliabadi
Copy link
Copy Markdown
Contributor

@AshkanAliabadi AshkanAliabadi commented Jun 24, 2020

No description provided.

@AshkanAliabadi AshkanAliabadi mentioned this pull request Jun 24, 2020
Closed
facebook-github-bot
facebook-github-bot reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshkanAliabadi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a30d140 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: False is not true 
  test_mem_leak (__main__.TestProfiler_cuda) 
Checks that there's no memory leak when using profiler with CUDA ... FAIL (6.822s) 
 
====================================================================== 
FAIL [6.822s]: test_mem_leak (__main__.TestProfiler_cuda) 
Checks that there's no memory leak when using profiler with CUDA 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "test_profiler.py", line 42, in test_mem_leak 
    self.assertTrue(max_diff < 100 * 1024) 
AssertionError: False is not true 
 
---------------------------------------------------------------------- 
Ran 1 test in 6.822s 
 
FAILED (failures=1) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestProfiler_cuda-20200624210701.xml 
Traceback (most recent call last): 
  File "run_test.py", line 727, in <module>
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

facebook-github-bot
facebook-github-bot reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshkanAliabadi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 25, 2020

@AshkanAliabadi merged this pull request in 71edd7f.

This was referenced Jul 1, 2020
Closed
Merged
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Update FP16 to FP16:4dfe081cf6bcd15db339cf2680b9281b8451eeb3. (pytorc…
245c076 
…h#40526)

Summary: Pull Request resolved: pytorch#40526

Differential Revision: D22215600

Pulled By: AshkanAliabadi

fbshipit-source-id: 6ff0c17d17f118b64ae34c0007b705c7127f07ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss dreiss approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AshkanAliabadi @facebook-github-bot @dreiss @mruberry