Unify torch/csrc/cuda/shared/cudnn.cpp include path#40525
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Unify torch/csrc/cuda/shared/cudnn.cpp include path#40525malfet wants to merge 1 commit intopytorch:masterfrom
torch/csrc/cuda/shared/cudnn.cpp include path#40525malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Move `USE_CUDNN` define under `USE_CUDA` guard, add `cuda/shared/cudnn.cpp` to filelist if either USE_ROCM or USE_CUDNN is set. This is a prep change for PyTorch CUDA src filelist unification change. Test Plan: CI Differential Revision: D22214899 fbshipit-source-id: 0a5563e968eba4f31d0db58fb4596316780317e0
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22214899 |
💊 CI failures summary and remediationsAs of commit 35fb232 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 2 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
Contributor
|
This pull request has been merged in c120fdc. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#40525 Move `USE_CUDNN` define under `USE_CUDA` guard, add `cuda/shared/cudnn.cpp` to filelist if either USE_ROCM or USE_CUDNN is set. This is a prep change for PyTorch CUDA src filelist unification change. Test Plan: CI Differential Revision: D22214899 fbshipit-source-id: b71b32fc603783b41cdef0e7fab2cc9cbe750a4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
USE_CUDNNdefine underUSE_CUDAguard, addcuda/shared/cudnn.cppto filelist if either USE_ROCM or USE_CUDNN is set.This is a prep change for PyTorch CUDA src filelist unification change.
Test Plan: CI
Differential Revision: D22214899