Fix backup solution#40515
Closed
seemethere wants to merge 3 commits intopytorch:masterfrom
Closed
Conversation
awscli was not loaded on conda builds and the backup upload did not work since it was a recursive copy instead of just specifically copying what we want. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
ezyang
approved these changes
Jun 24, 2020
malfet
approved these changes
Jun 24, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@seemethere merged this pull request in adcd755. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: These were changes that had to be made in the `release/1.6` branch in order to get backups to work. They should be brought to the master branch. Pull Request resolved: pytorch#40515 Differential Revision: D22221308 Pulled By: seemethere fbshipit-source-id: 24e2a0196a8e775fe324a383c8f0c681118b741b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were changes that had to be made in the
release/1.6branch in order to get backups to work.They should be brought to the master branch.