[jit] fix dictConstruct order issue#40424
Closed
wanchaol wants to merge 1 commit intogh/wanchaol/116/basefrom
Closed
[jit] fix dictConstruct order issue#40424wanchaol wants to merge 1 commit intogh/wanchaol/116/basefrom
wanchaol wants to merge 1 commit intogh/wanchaol/116/basefrom
Conversation
dictConstruct should preserve the inputs order [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit db8447a (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
eellison
approved these changes
Jun 23, 2020
Contributor
wanchaol
added a commit
to wanchaol/pytorch
that referenced
this pull request
Jun 30, 2020
A combination of pytorch#39601 and pytorch#40424 both are approved and merged in master
malfet
pushed a commit
that referenced
this pull request
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
dictConstruct should preserve the inputs order
Differential Revision: D22202690