Skip to content

[NCCL Docs] Adding Comments for Work-level Finish in ProcessGroup#40404

Closed
osalpekar wants to merge 2 commits intogh/osalpekar/45/basefrom
gh/osalpekar/45/head
Closed

[NCCL Docs] Adding Comments for Work-level Finish in ProcessGroup#40404
osalpekar wants to merge 2 commits intogh/osalpekar/45/basefrom
gh/osalpekar/45/head

Conversation

@osalpekar
Copy link
Copy Markdown
Contributor

@osalpekar osalpekar commented Jun 22, 2020 •
edited
Loading

Stack from ghstack:

Adds docs to the finish function in ProcessGroup::Work. It's better to have some documentation around these functions since we have some PR's with API-changes/optimizations for these work-level functions here and in the subclasses.

Differential Revision: D22174891

@osalpekar
[NCCL Docs] Adding Comments for Work-level Finish in ProcessGroup
616995c 
Adds docs to the finish function in ProcessGroup::Work. It's better to have some documentation around these functions since we have some PR's with API-changes/optimizations for these work-level functions here and in the subclasses.

Differential Revision: [D22174891](https://our.internmc.facebook.com/intern/diff/D22174891/)

[ghstack-poisoned]
@osalpekar osalpekar mentioned this pull request Jun 22, 2020
Closed
@osalpekar
Update on "[NCCL Docs] Adding Comments for Work-level Finish in Proce…
b5f1712 
…ssGroup"

Adds docs to the finish function in ProcessGroup::Work. It's better to have some documentation around these functions since we have some PR's with API-changes/optimizations for these work-level functions here and in the subclasses.

Differential Revision: [D22174891](https://our.internmc.facebook.com/intern/diff/D22174891/)

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b5f1712 (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 23 00:18:01 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jun 23 00:18:01 processing existing schema:  __str__(__torch__.torch.classes._TorchScriptTesting._StackString _0) -> (str _0) 
Jun 23 00:18:01 processing existing schema:  __init__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jun 23 00:18:01 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int[] _0) 
Jun 23 00:18:01 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jun 23 00:18:01 processing existing schema:  top(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jun 23 00:18:01 processing existing schema:  pop(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jun 23 00:18:01 processing existing schema:  get(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, Tensor _1) -> (str _0) 
Jun 23 00:18:01 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0) -> (int _0) 
Jun 23 00:18:01 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, int _1) -> (None _0) 
Jun 23 00:18:01 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Jun 23 00:18:01 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Jun 23 00:18:01  
Jun 23 00:18:01 Broken ops: [ 
Jun 23 00:18:01 	aten::mkldnn_max_pool3d(Tensor self, int[3] kernel_size, int[3] stride=[], int[3] padding=[0, 0, 0], int[3] dilation=[1, 1, 1], bool ceil_mode=False) -> (Tensor) 
Jun 23 00:18:01 	aten::mkldnn_reorder_conv3d_weight(Tensor self, int[3] padding=[0, 0, 0], int[3] stride=[1, 1, 1], int[3] dilation=[1, 1, 1], int groups=1) -> (Tensor) 
Jun 23 00:18:01 ] 
Jun 23 00:18:01 + cleanup 
Jun 23 00:18:01 + retcode=1 
Jun 23 00:18:01 + set +x 
Jun 23 00:18:01 =================== sccache compilation log =================== 
Jun 23 00:18:01 =========== If your build fails, please take a look at the log above for possible reasons ===========

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_python_doc_push Doc Build and Push 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 24, 2020

This pull request has been merged in 3e2d2fc.

@facebook-github-bot facebook-github-bot deleted the gh/osalpekar/45/head branch June 28, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@osalpekar @facebook-github-bot
[NCCL Docs] Adding Comments for Work-level Finish in ProcessGroup (py…
53b34d8 
…torch#40404)

Summary:
Pull Request resolved: pytorch#40404

Adds docs to the finish function in ProcessGroup::Work. It's better to have some documentation around these functions since we have some PR's with API-changes/optimizations for these work-level functions here and in the subclasses.
ghstack-source-id: 106381736

Test Plan: CI (Docs change only)

Differential Revision: D22174891

fbshipit-source-id: 7901ea3b35caf6f69f37178ca574104d3412de28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiayisuse jiayisuse jiayisuse approved these changes

@mrshenli mrshenli mrshenli approved these changes

@pietern pietern Awaiting requested review from pietern

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@osalpekar @facebook-github-bot @jiayisuse @mrshenli @mruberry