Implement NLLLossNd#4035
Merged
soumith merged 3 commits intopytorch:masterfrom Dec 18, 2017
Merged
Conversation
apaszke
reviewed
Dec 5, 2017
| 'KLDivLoss': kldivloss_reference, | ||
| 'NLLLoss': nllloss_reference, | ||
| 'NLLLoss2d': nllloss2d_reference, | ||
| 'NLLLossNd': nlllossNd_reference, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@pytorchbot retest this please |
Contributor
|
There was some CI maintenance happening this morning -- retriggering build. @pytorchbot retest this please |
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
* Implement NLLLossNd * Fix tests and typos * Fix tests
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Implement NLLLossNd * Fix tests and typos * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #3556
I'm not sure this is the best way to implement because the
.contiguous()calls might be slow.One alternative way to implement this is to copy and modify gather. Without any of the extra keyword modifiers, with
reduce=False, the following is equivalent to NLLLossNd:I tried benchmarking this against what I have right now (this diff that uses
.contiguous()calls and NLLLoss2d) and using gather is around 2x slower, even for non-contiguous inputs, so I went with this approach.Test Plan
Unit tests for NLLLossNd with a NLLLossNd reference function