[NCCL] Explicitly Abort NCCL Communicators on Process Group Destruction#40241
Closed
osalpekar wants to merge 3 commits intogh/osalpekar/43/basefrom
Closed
[NCCL] Explicitly Abort NCCL Communicators on Process Group Destruction#40241osalpekar wants to merge 3 commits intogh/osalpekar/43/basefrom
osalpekar wants to merge 3 commits intogh/osalpekar/43/basefrom
Conversation
We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)! [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Jun 18, 2020
We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)! ghstack-source-id: 106103869 Pull Request resolved: #40241
…p Destruction" We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)! [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Jun 22, 2020
Pull Request resolved: #40241 We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 ghstack-source-id: 106368499 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)!
…p Destruction" We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)! [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Jun 23, 2020
Pull Request resolved: #40241 We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: #32231 ghstack-source-id: 106469423 Differential Revision: [D22103662](https://our.internmc.facebook.com/intern/diff/D22103662/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22103662/)!
💊 CI failures summary and remediationsAs of commit d11f7e4 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Contributor
Author
|
Approved internally on Phabricator |
Contributor
|
This pull request has been merged in 527ab13. |
Contributor
|
reverting this PR, as c10d test got flaky since this PR https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-xenial-rocm3.3-py3.6-test2/2040//console |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…on (pytorch#40241) Summary: Pull Request resolved: pytorch#40241 We abort incomplete NCCL Communicators in the ProcessGroupNCCL destructor, otherwise pending NCCL communciators may block other CUDA ops. Closes: pytorch#32231 ghstack-source-id: 106469423 Test Plan: CI/Sandcastle Reviewed By: jiayisuse Differential Revision: D22103662 fbshipit-source-id: 1f6f88b56bd7a5e9ca5a41698995a76e60e8ad9f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We abort incomplete NCCL Communicators in the ProcessGroupNCCL
destructor, otherwise pending NCCL communciators may block other CUDA ops.
Closes: #32231
Differential Revision: D22103662
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!