Skip to content

[Reland #4] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h#40211

Closed
pbelevich wants to merge 1 commit intomasterfrom
ci-all/at_parallel
Closed

[Reland #4] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h#40211
pbelevich wants to merge 1 commit intomasterfrom
ci-all/at_parallel

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Jun 18, 2020 •
edited
Loading

Fixes #39471

Reland of #39612 #39881 #40045 #40122

Proof: green TBB test

facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Jun 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 73c0e10 (more details on the Dr. CI page):

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 18 16:42:44 TIMEOUT: //:integration_test (Summary) 
Jun 18 16:41:29 [       OK ] RNNTest.UsePackedSequenceAsInput (31 ms) 
Jun 18 16:41:29 [----------] 11 tests from RNNTest (106024 ms total) 
Jun 18 16:41:29  
Jun 18 16:41:29 [----------] Global test environment tear-down 
Jun 18 16:41:29 [==========] 11 tests from 1 test suite ran. (106024 ms total) 
Jun 18 16:41:29 [  PASSED  ] 11 tests. 
Jun 18 16:41:29 ================================================================================ 
Jun 18 16:41:31 [2,585 / 2,587] 23 / 25 tests; Testing //:integration_test; 241s processwrapper-sandbox ... (2 actions running) 
Jun 18 16:42:44 [2,585 / 2,587] 23 / 25 tests; Testing //:integration_test; 315s processwrapper-sandbox ... (2 actions running) 
Jun 18 16:42:44  
Jun 18 16:42:44 TIMEOUT: //:integration_test (Summary) 
Jun 18 16:42:44       /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/execroot/pytorch/bazel-out/k8-fastbuild/testlogs/integration_test/test.log 
Jun 18 16:42:44 INFO: From Testing //:integration_test: 
Jun 18 16:42:44 ==================== Test output for //:integration_test: 
Jun 18 16:42:44 Running main() from gmock_main.cc 
Jun 18 16:42:44 Note: Google Test filter = -*CUDA 
Jun 18 16:42:44 [==========] Running 1 test from 1 test suite. 
Jun 18 16:42:44 [----------] Global test environment set-up. 
Jun 18 16:42:44 [----------] 1 test from IntegrationTest 
Jun 18 16:42:44 [ RUN      ] IntegrationTest.CartPole 
Jun 18 16:42:44 -- Test timed out at 2020-06-18 16:42:29 UTC --

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 14 times.

@pbelevich pbelevich force-pushed the ci-all/at_parallel branch from 82ae470 to 1d3e1d2 Compare June 18, 2020 03:43
facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@pbelevich pbelevich force-pushed the ci-all/at_parallel branch from 1d3e1d2 to f39c513 Compare June 18, 2020 13:46
facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@pbelevich pbelevich force-pushed the ci-all/at_parallel branch 2 times, most recently from 843eb49 to d3c3892 Compare June 18, 2020 15:03
@pbelevich pbelevich force-pushed the ci-all/at_parallel branch from d3c3892 to 73c0e10 Compare June 18, 2020 16:04
facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@pbelevich pbelevich requested a review from ezyang June 18, 2020 18:46
@pbelevich pbelevich marked this pull request as ready for review June 18, 2020 18:46
@pbelevich pbelevich requested a review from malfet June 18, 2020 18:47
facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2020

@pbelevich merged this pull request in ccea372.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
@pbelevich @xwang233
[Reland pytorch#4] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_P…
501c44b 
…ARALLEL_NATIVE_TBB to ATen/Config.h (pytorch#40211)

Summary:
Fixes pytorch#39471

Reland of pytorch#39612 pytorch#39881 pytorch#40045 pytorch#40122

Proof: [green TBB test](https://app.circleci.com/pipelines/github/pytorch/pytorch/182769/workflows/ae9f4f7a-791a-49df-9625-e2f0a51e70e7/jobs/5910591/steps)
Pull Request resolved: pytorch#40211

Reviewed By: malfet

Differential Revision: D22128537

Pulled By: pbelevich

fbshipit-source-id: 98c589405daafc2c81f76e1d5c1aef5e57065351
@facebook-github-bot facebook-github-bot deleted the ci-all/at_parallel branch July 13, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h

4 participants

@pbelevich @facebook-github-bot @malfet @mruberry