Add `torch.count_nonzero` by kshitij12345 · Pull Request #39992 · pytorch/pytorch

kshitij12345 · 2020-06-13T15:21:50Z

Reference #38349

TODO:

Add tests
Add docs (pending add to docs.rst)

dr-ci · 2020-06-13T16:34:21Z

💊 CI failures summary and remediations

As of commit 61a9937 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1/1 broken upstream at merge base 4a0ba62 on Jun 24 from 10:20am to 5:16pm PDT (23 commits; 597cb04 - e12f73e)

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

pytorch_bazel_test on Jun 24 from 10:20am to 5:16pm PDT (23 commits; 597cb04 - e12f73e)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 46 times.

kshitij12345 · 2020-06-14T15:07:54Z

@mruberry

Please review

mruberry

Hey @kshitij12345, thanks for the PR! I added some comments.

Summary + followup checklist:

Suggestion to simplify test in test_torch.py
Minor doc improvements
Method variants
Add a "not_implemented" entry to tools/autograd/derivatives.yaml
Update docs/source/name_inference.rst
Update docs/source/tensors.rst and docs/source/torch.rst
Update torch/_torch_docs.py

Overall this is really good, it just needs a few updates.

kshitij12345 · 2020-06-15T18:19:50Z

@mruberry
Thanks for the great review with summary!

I believe have addressed the comments. Please review.

mruberry

A few more test changes (sorry about that, I made a note to make self.compare_with_numpy easier to use!) and I suggest you remove the name variant to keep this PR more focused, otherwise you'll need to add tests for it, and that could be a separate PR if you wanted.

Also I made a note on the name_inference.rst doc.

* scale the randomly generated values to have bigger range for intergral. * pass the input data as tolist(), this will force compare_with_numpy, to obey the passed device and dtype.

mruberry · 2020-06-16T09:45:08Z

#40064 clarifies the compare_with_numpy behavior, thank you for revealing an issue with it. You will have to rebase after it goes in, unfortunately, but the code change it requires is very small. We really want to avoid those tolist() calls.

* add extremal case for floating dtypes.

kshitij12345 · 2020-06-16T18:24:13Z

@mruberry

PTAL:)

kshitij12345 · 2020-06-18T05:41:44Z

@mruberry

Would be great if you can have another look at this. I am planning to use the _generate_input and _test_reduction_function_with_numpy for few tests for nansum.

Thank You.

mruberry

Excellent work. This looks really good, @kshitij12345!

Should the test also consider complex dtypes?

kshitij12345 · 2020-06-22T03:39:49Z

@mruberry

Have added complex dtypes to the test as well.
I guess that should cover all the bases.

mruberry · 2020-06-24T05:24:17Z

@mruberry

Have added complex dtypes to the test as well.
I guess that should cover all the bases.

Thanks kshitij12345! We just need to wait for the tests again since there was a merge conflict with master.

mruberry · 2020-06-24T23:28:43Z

Another merge conflict, unfortunately. We'll have to wait for the tests again.

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kshitij12345 · 2020-06-27T07:38:22Z

@mruberry Gentle ping :)

mruberry · 2020-06-27T22:27:18Z

@mruberry Gentle ping :)

Thanks for the ping. I'm fighting with our internal landing system, unfortunately.

kshitij12345 · 2020-06-28T06:35:07Z

Oh. Sure. Thank You! :)

Summary: Reference pytorch#38349 TODO: * [x] Add tests * [x] Add docs (pending add to docs.rst) Pull Request resolved: pytorch#39992 Reviewed By: ezyang Differential Revision: D22236738 Pulled By: mruberry fbshipit-source-id: 8520068b086b5ffc4de9e4939e746ff889293987

add count_nonzero

07f93a5

kshitij12345 changed the title ~~Add torch.count_nonzero~~ [WIP] Add torch.count_nonzero Jun 13, 2020

kshitij12345 marked this pull request as draft June 13, 2020 15:22

kshitij12345 added 3 commits June 14, 2020 13:07

add test to test_torch

6cbfbf6

update docs and overrides

3a55cf5

add to aten_interned_strings

4a4ac4b

kshitij12345 marked this pull request as ready for review June 14, 2020 15:07

kshitij12345 changed the title ~~[WIP] Add torch.count_nonzero~~ Add torch.count_nonzero Jun 14, 2020

mruberry self-requested a review June 15, 2020 07:35

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread aten/src/ATen/native/native_functions.yaml Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread torch/_torch_docs.py Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread torch/_torch_docs.py Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

mruberry requested changes Jun 15, 2020

View reviewed changes

kshitij12345 added 5 commits June 15, 2020 23:02

support named dimensions

fba2680

update rst files

b3afd10

simplify test

a5edde9

mark gradient not implemented

5680c16

update docs

bd0575e

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread docs/source/name_inference.rst Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

mruberry reviewed Jun 15, 2020

View reviewed changes

Comment thread aten/src/ATen/native/native_functions.yaml Outdated

mruberry requested changes Jun 15, 2020

View reviewed changes

kshitij12345 added 2 commits June 16, 2020 11:17

remove named tensor support

dd13edd

address comments

f233264

* scale the randomly generated values to have bigger range for intergral. * pass the input data as tolist(), this will force compare_with_numpy, to obey the passed device and dtype.

test structure fix

aac2df8

kshitij12345 added 3 commits June 16, 2020 17:04

address comment

04611b2

* add extremal case for floating dtypes.

minor generate restructure

0e72c8e

Merge branch 'master' into numpy/cnt_nonzero

b92f294

mruberry reviewed Jun 18, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

mruberry approved these changes Jun 18, 2020

View reviewed changes

kshitij12345 added 2 commits June 20, 2020 10:48

test for complex dtypes

94c3376

Merge branch 'master' into numpy/cnt_nonzero

fd038cb

pytorchbot added the open source label Jun 22, 2020

Merge branch 'master' into numpy/cnt_nonzero

d83f809

Merge branch 'master' into numpy/cnt_nonzero

61a9937

facebook-github-bot reviewed Jun 25, 2020

View reviewed changes

mruberry mentioned this pull request Jun 30, 2020

Add nanprod to ReduceOps #38634

Closed

2 tasks

facebook-github-bot closed this in 4104ab8 Jun 30, 2020

mruberry mentioned this pull request Jun 30, 2020

NumPy-like Functionality Request Rollup #38349

Closed

41 tasks

Conversation

kshitij12345 commented Jun 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Jun 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🚧 1 fixed upstream failure:

Uh oh!

kshitij12345 commented Jun 14, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

kshitij12345 commented Jun 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

mruberry commented Jun 16, 2020

Uh oh!

kshitij12345 commented Jun 16, 2020

Uh oh!

kshitij12345 commented Jun 18, 2020

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

kshitij12345 commented Jun 22, 2020

Uh oh!

mruberry commented Jun 24, 2020

Uh oh!

mruberry commented Jun 24, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

kshitij12345 commented Jun 27, 2020

Uh oh!

mruberry commented Jun 27, 2020

Uh oh!

kshitij12345 commented Jun 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kshitij12345 commented Jun 13, 2020 •

edited

Loading

dr-ci Bot commented Jun 13, 2020 •

edited

Loading