Skip to content

[v1.5.1][ONNX] Fix pow op export (#38065)#39685

Closed
gchanan wants to merge 1 commit intopytorch:release/1.5from
gchanan:15_38065
Closed

[v1.5.1][ONNX] Fix pow op export (#38065)#39685
gchanan wants to merge 1 commit intopytorch:release/1.5from
gchanan:15_38065

Conversation

@gchanan
Copy link
Copy Markdown
Contributor

@gchanan gchanan commented Jun 8, 2020

Summary:
Fix pow type cast for opset 9 and update opset 12
Pull Request resolved: #38065

Differential Revision: D21485353

Pulled By: malfet

fbshipit-source-id: 3993e835ffad07b2e6585eb5cf1cb7c8474de2ec

@neginraoof @gchanan
[ONNX] Fix pow op export (pytorch#38065)
09731ce 
Summary:
Fix pow type cast for opset 9 and update opset 12
Pull Request resolved: pytorch#38065

Differential Revision: D21485353

Pulled By: malfet

fbshipit-source-id: 3993e835ffad07b2e6585eb5cf1cb7c8474de2ec
@gchanan gchanan added this to the 1.5.1 milestone Jun 8, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 9, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 09731ce (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build caffe2_onnx_ort2_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_pow FAILED [ 80%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_mean SKIPPED [ 78%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_mean_ignore_index SKIPPED [ 78%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_mean_ignore_index_weights SKIPPED [ 78%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_mean_weights SKIPPED [ 78%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_none SKIPPED [ 79%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_nllloss_2d_sum SKIPPED [ 79%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_one_hot PASSED [ 79%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_onnx_proto_checker PASSED [ 80%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_pad_types PASSED [ 80%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_pixel_shuffle SKIPPED [ 80%] 
Jun 09 00:38:23 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_pow FAILED [ 80%] 
Jun 09 00:38:45 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_r2plus1d_18_video PASSED [ 81%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_r3d_18_video PASSED [ 81%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_random PASSED [ 81%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_random_dynamic_size PASSED [ 81%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_random_like PASSED [ 82%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_random_like_dtype PASSED [ 82%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_reduce_log_sum_exp PASSED [ 82%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_reflection_pad PASSED [ 83%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_remainder PASSED [ 83%] 
Jun 09 00:39:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset12::test_remainder_scalar PASSED [ 83%]

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_xla_linux_xenial_py3_6_clang7_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 09 00:15:09 RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (Unknown: Could not start gRPC server vs. OK) 
Jun 09 00:15:09 ====================================================================== 
Jun 09 00:15:09 ERROR [0.000s]: setUpClass (__main__.TestViewOpsXLA) 
Jun 09 00:15:09 ---------------------------------------------------------------------- 
Jun 09 00:15:09 Traceback (most recent call last): 
Jun 09 00:15:09   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 354, in setUpClass 
Jun 09 00:15:09     cls.primary_device = str(xm.xla_device()) 
Jun 09 00:15:09   File "/opt/conda/lib/python3.6/site-packages/torch_xla-0.8-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 137, in xla_device 
Jun 09 00:15:09     devkind=[devkind] if devkind is not None else None) 
Jun 09 00:15:09   File "/opt/conda/lib/python3.6/site-packages/torch_xla-0.8-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 41, in get_xla_supported_devices 
Jun 09 00:15:09     xla_devices = torch_xla._XLAC._xla_get_devices() 
Jun 09 00:15:09 RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (Unknown: Could not start gRPC server vs. OK) 
Jun 09 00:15:09  
Jun 09 00:15:09 ---------------------------------------------------------------------- 
Jun 09 00:15:09 Ran 0 tests in 0.098s 
Jun 09 00:15:09  
Jun 09 00:15:09 FAILED (errors=1) 
Jun 09 00:15:09  
Jun 09 00:15:09 Generating XML reports... 
Jun 09 00:15:10 + cleanup 
Jun 09 00:15:10 + retcode=1 
Jun 09 00:15:10 + set +x
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@houseroad
Copy link
Copy Markdown
Member

houseroad commented Jun 9, 2020

Seems this change also requires onnx runtime upgrade. Try bump up the ort version to the same version as the master: https://github.com/pytorch/pytorch/blob/master/.jenkins/caffe2/test.sh#L151

cc: @neginraoof @KsenijaS @spandantiwari

malfet added a commit that referenced this pull request Jun 10, 2020
@malfet
Update ort-nighly as suggested in #39685 (comment)
c705ed5
@malfet malfet mentioned this pull request Jun 10, 2020
Merged
malfet added a commit to malfet/pytorch that referenced this pull request Jun 11, 2020
@malfet
Update ort-nighly version as suggested in pytorch#39685 (comment)
3bb338a
seemethere pushed a commit that referenced this pull request Jun 11, 2020
@malfet @neginraoof
[ONNX] Fix pow op export [1.5.1] (#39791)
3c31d73 
* [ONNX] Fix pow op export (#38065)

Summary:
Fix pow type cast for opset 9 and update opset 12
Pull Request resolved: #38065

Differential Revision: D21485353

Pulled By: malfet

fbshipit-source-id: 3993e835ffad07b2e6585eb5cf1cb7c8474de2ec

* Update ort-nighly version as suggested in #39685 (comment)

* Apply changes from #37846 to  `test_topk_smallest_unsorted`

Co-authored-by: neginraoof <neginmr@utexas.edu>
@seemethere
Copy link
Copy Markdown
Member

seemethere commented Jun 11, 2020

Closed in favor of #39791

@seemethere seemethere closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@gchanan @houseroad @seemethere @neginraoof