Remove hacky double registration of to_here op in reg_distributed_ops#39602
Closed
rohan-varma wants to merge 6 commits intogh/rohan-varma/136/basefrom
Closed
Remove hacky double registration of to_here op in reg_distributed_ops#39602rohan-varma wants to merge 6 commits intogh/rohan-varma/136/basefrom
rohan-varma wants to merge 6 commits intogh/rohan-varma/136/basefrom
Conversation
This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
This was referenced Jun 5, 2020
Closed
rohan-varma
added a commit
that referenced
this pull request
Jun 5, 2020
This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) ghstack-source-id: 105370320 Pull Request resolved: #39602
mrshenli
approved these changes
Jun 6, 2020
…ributed_ops" This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 8, 2020
Pull Request resolved: #39602 This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105424163 Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/)
💊 CI failures summary and remediationsAs of commit bf3c5f5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 25 times. |
…ributed_ops" This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 13, 2020
Pull Request resolved: #39602 This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105838088 Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/)
…ributed_ops" This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 15, 2020
Pull Request resolved: #39602 This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105911881 Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/)
…ributed_ops" This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 16, 2020
Pull Request resolved: #39602 This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105954938 Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/)
xush6528
requested changes
Jun 16, 2020
| Operator( | ||
| "aten::to_here(RRef(t) self, double timeout) -> t(*)", | ||
| fmt::format( | ||
| "aten::to_here(RRef(t) self, float timeout = {}) -> t", |
Contributor
There was a problem hiding this comment.
"aten::to_here(RRef(t) self, float timeout = {}) -> t(*)",
…ributed_ops" This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 16, 2020
Pull Request resolved: #39602 This was added as a part of #38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105983645 Differential Revision: [D21912719](https://our.internmc.facebook.com/intern/diff/D21912719/)
xush6528
approved these changes
Jun 16, 2020
Contributor
|
This pull request has been merged in 03529ed. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
…pytorch#39602) Summary: Pull Request resolved: pytorch#39602 This was added as a part of pytorch#38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105983645 Test Plan: Ci Differential Revision: D21912719 fbshipit-source-id: 7525c1322a95126f529301be142248af48565b82
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…pytorch#39602) Summary: Pull Request resolved: pytorch#39602 This was added as a part of pytorch#38590 but we can use default arguments here. We use fmt:;format to bind the default value to the rpc timeout at runtime. ghstack-source-id: 105983645 Test Plan: Ci Differential Revision: D21912719 fbshipit-source-id: 7525c1322a95126f529301be142248af48565b82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This was added as a part of
#38590 but we can use default arguments
here. We use fmt:;format to bind the default value to the rpc timeout at
runtime.
Differential Revision: D21912719