Skip to content

[Debug-Only] Explicitly decref in UnpickledPythonCall dtor#39505

Closed
mrshenli wants to merge 7 commits intogh/mrshenli/187/basefrom
gh/mrshenli/187/head
Closed

[Debug-Only] Explicitly decref in UnpickledPythonCall dtor#39505
mrshenli wants to merge 7 commits intogh/mrshenli/187/basefrom
gh/mrshenli/187/head

Conversation

@mrshenli
Copy link
Copy Markdown
Contributor

@mrshenli mrshenli commented Jun 4, 2020 •
edited
Loading

Stack from ghstack:

@mrshenli mrshenli mentioned this pull request Jun 4, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 4, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 902b74c (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
Auto-merging torch/csrc/distributed/rpc/rref_context.cpp 
CONFLICT (content): Merge conflict in torch/csrc/distributed/rpc/rref_context.cpp 
Auto-merging torch/csrc/distributed/rpc/request_callback_impl.cpp 
Auto-merging torch/csrc/distributed/rpc/python_functions.h 
Auto-merging torch/csrc/distributed/rpc/python_functions.cpp 
CONFLICT (content): Merge conflict in torch/csrc/distributed/rpc/python_functions.cpp 
Auto-merging torch/csrc/distributed/rpc/init.cpp 
Removing tools/amd_build/patches/a_torch_cuda___init__.py.patch 
Removing test/test_openmp.py 
Removing test/test_docs_coverage.py 
Automatic merge failed; fix conflicts and then commit the result.

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
Auto-merging torch/csrc/distributed/rpc/rref_context.cpp 
CONFLICT (content): Merge conflict in torch/csrc/distributed/rpc/rref_context.cpp 
Auto-merging torch/csrc/distributed/rpc/request_callback_impl.cpp 
Auto-merging torch/csrc/distributed/rpc/python_functions.h 
Auto-merging torch/csrc/distributed/rpc/python_functions.cpp 
CONFLICT (content): Merge conflict in torch/csrc/distributed/rpc/python_functions.cpp 
Auto-merging torch/csrc/distributed/rpc/init.cpp 
Removing tools/amd_build/patches/a_torch_cuda___init__.py.patch 
Removing test/test_openmp.py 
Removing test/test_docs_coverage.py 
Automatic merge failed; fix conflicts and then commit the result.

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 23 times.

mrshenli added a commit that referenced this pull request Jun 4, 2020
@mrshenli
[Debug-Only] Explicitly decref in UnpickledPythonCall dtor
e38deb2 
ghstack-source-id: ae8a6af
Pull Request resolved: #39505
mrshenli added a commit that referenced this pull request Jun 4, 2020
@mrshenli
[Debug-Only] Explicitly decref in UnpickledPythonCall dtor
a5593fb 
ghstack-source-id: 72454f9
Pull Request resolved: #39505
mrshenli added a commit that referenced this pull request Jun 5, 2020
@mrshenli
[Debug-Only] Explicitly decref in UnpickledPythonCall dtor
09ea156 
ghstack-source-id: 9a1aaa5
Pull Request resolved: #39505
@mrshenli mrshenli closed this Jun 10, 2020
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/187/head branch July 10, 2020 14:18
@atalman atalman mentioned this pull request May 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrshenli