observer bench: add CUDA#39360
Closed
vkuzo wants to merge 4 commits intogh/vkuzo/80/basefrom
Closed
Conversation
Summary: Makes the observer microbenchmarks also run on CUDA. This is useful now that QAT is supported in DDP and is more likely to be run on GPUs. Test Plan: ``` python -m pt.qobserver_test ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f740838 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
z-a-f
approved these changes
Jun 4, 2020
Summary: Makes the observer microbenchmarks also run on CUDA. This is useful now that QAT is supported in DDP and is more likely to be run on GPUs. Test Plan: ``` python -m pt.qobserver_test ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21828985](https://our.internmc.facebook.com/intern/diff/D21828985) [ghstack-poisoned]
Summary: Makes the observer microbenchmarks also run on CUDA. This is useful now that QAT is supported in DDP and is more likely to be run on GPUs. Test Plan: ``` python -m pt.qobserver_test ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21828985](https://our.internmc.facebook.com/intern/diff/D21828985) [ghstack-poisoned]
Summary: Makes the observer microbenchmarks also run on CUDA. This is useful now that QAT is supported in DDP and is more likely to be run on GPUs. Test Plan: ``` python -m pt.qobserver_test ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21828985](https://our.internmc.facebook.com/intern/diff/D21828985) [ghstack-poisoned]
Contributor
|
This pull request has been merged in e35199a. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#39360 Makes the observer microbenchmarks also run on CUDA. This is useful now that QAT is supported in DDP and is more likely to be run on GPUs. Test Plan: ``` python -m pt.qobserver_test ``` Imported from OSS Differential Revision: D21828985 fbshipit-source-id: 6da4d61f744f7a2ee5e87963b3ec84579128d435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Makes the observer microbenchmarks also run on CUDA. This is useful
now that QAT is supported in DDP and is more likely to be run
on GPUs.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21828985