Skip to content

Collect and upload error logs if VisualStudio installation fails#38902

Closed
malfet wants to merge 2 commits intopytorch:masterfrom
malfet:malfet/collect-vs-installation-error-logs
Closed

Collect and upload error logs if VisualStudio installation fails#38902
malfet wants to merge 2 commits intopytorch:masterfrom
malfet:malfet/collect-vs-installation-error-logs

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented May 22, 2020

Add store_artifacts attribtue to Windows build jobs
In vs_install.ps1 add logic to download vscollect tool and upload collected results as build artifacts

malfet added 2 commits May 21, 2020 19:04
@malfet
Collect and upload error logs if VisualStudio installation fails
6e10fa4 
Add `store_artifacts` attribtue to Windows build jobs
In `vs_install.ps1` add logic to download vscollect tool and upload collected results as build artifacts
@malfet
Also, update FBGEMM hashsum
fc208b9
@malfet malfet requested a review from peterjc123 May 22, 2020 02:06
@malfet malfet force-pushed the malfet/collect-vs-installation-error-logs branch from 08cf887 to fc208b9 Compare May 22, 2020 02:06
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fc208b9 (more details on the Dr. CI page):

  • 4/4 failures possibly* introduced in this PR
    • 2/4 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

May 22 02:23:58 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n return ((int*)(&strtod_l))[argc];\n ^\n1 error generated.\n" } 
May 22 02:23:57     self.run(build_args, my_env) 
May 22 02:23:57   File "/var/lib/jenkins/workspace/tools/setup_helpers/cmake.py", line 141, in run 
May 22 02:23:57     check_call(command, cwd=self.build_dir, env=env) 
May 22 02:23:57   File "/opt/conda/lib/python3.6/subprocess.py", line 311, in check_call 
May 22 02:23:57     raise CalledProcessError(retcode, cmd) 
May 22 02:23:57 subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '3']' returned non-zero exit status 2. 
May 22 02:23:57 + cleanup 
May 22 02:23:57 + retcode=1 
May 22 02:23:57 + set +x 
May 22 02:23:57 =================== sccache compilation log =================== 
May 22 02:23:58 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n  return ((int*)(&strtod_l))[argc];\n                  ^\n1 error generated.\n" } 
May 22 02:23:58  
;32m               ^\n\u{1b}[0m\u{1b}[1m/var/lib/jenkins/workspace/c10/core/Storage.h:7:16: \u{1b}[0m\u{1b}[0;1;30mnote: \u{1b}[0mcandidate constructor (the implicit move constructor) not viable: requires 1 argument, but 6 were provided\u{1b}[0m\n\u{1b}[1m/var/lib/jenkins/workspace/c10/core/Storage.h:11:3: \u{1b}[0m\u{1b}[0;1;30mnote: \u{1b}[0mcandidate constructor not viable: requires 0 arguments, but 6 were provided\u{1b}[0m\n  Storage() {}\n\u{1b}[0;1;32m  ^\n\u{1b}[0m1 error generated.\n" } 
May 22 02:23:58  
May 22 02:23:58 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 22 02:23:58 Compile requests               5697 
May 22 02:23:58 Compile requests executed      3408 
May 22 02:23:58 Cache hits                     3380 
May 22 02:23:58 Cache misses                     11 
May 22 02:23:58 Cache timeouts                    0 
May 22 02:23:58 Cache read errors                 0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

atus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function)\n return ((int*)(&strtod_l))[argc];\n ^\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
May 22 02:24:05     self.run(build_args, my_env) 
May 22 02:24:05   File "/var/lib/jenkins/workspace/tools/setup_helpers/cmake.py", line 141, in run 
May 22 02:24:05     check_call(command, cwd=self.build_dir, env=env) 
May 22 02:24:05   File "/opt/conda/lib/python3.6/subprocess.py", line 311, in check_call 
May 22 02:24:05     raise CalledProcessError(retcode, cmd) 
May 22 02:24:05 subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '3']' returned non-zero exit status 2. 
May 22 02:24:05 + cleanup 
May 22 02:24:05 + retcode=1 
May 22 02:24:05 + set +x 
May 22 02:24:05 =================== sccache compilation log =================== 
tus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function)\n   return ((int*)(&strtod_l))[argc];\n                   ^\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
May 22 02:24:05  
nkins/workspace/c10/core/Storage.h:7:16:\u{1b}[m\u{1b}[K \u{1b}[01;36m\u{1b}[Knote: \u{1b}[m\u{1b}[K  candidate expects 1 argument, 6 provided\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/c10/core/Storage.h:7:16:\u{1b}[m\u{1b}[K \u{1b}[01;36m\u{1b}[Knote: \u{1b}[m\u{1b}[Kcandidate: c10::Storage::Storage(c10::Storage&&)\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/c10/core/Storage.h:7:16:\u{1b}[m\u{1b}[K \u{1b}[01;36m\u{1b}[Knote: \u{1b}[m\u{1b}[K  candidate expects 1 argument, 6 provided\n" } 
May 22 02:24:05  
May 22 02:24:05 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 22 02:24:05 Compile requests               5661 
May 22 02:24:05 Compile requests executed      3390 
May 22 02:24:05 Cache hits                     3365 
May 22 02:24:05 Cache misses                      9 
May 22 02:24:05 Cache timeouts                    0 
May 22 02:24:05 Cache read errors                 0

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

peterjc123
peterjc123 reviewed May 22, 2020
View reviewed changes
Comment thread .circleci/scripts/vs_install.ps1
}
Start-Process "${PWD}\Collect.exe" -NoNewWindow -Wait -PassThru
New-Item -Path "C:\Users\circleci\project" -Name "build-results" -ItemType "directory"
Copy-Item -Path "C:\Users\circleci\AppData\Local\Temp\vslogs.zip" -Destination "C:\Users\circleci\project\build-results\"
Copy link
Copy Markdown
Collaborator

@peterjc123 peterjc123 May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add a message and say that the log is uploaded as the artifact.

facebook-github-bot
facebook-github-bot reviewed May 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet deleted the malfet/collect-vs-installation-error-logs branch May 22, 2020 03:35
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 22, 2020

@malfet merged this pull request in 22454c5.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@malfet @facebook-github-bot
Collect and upload error logs if VisualStudio installation fails (pyt…
0554b1d 
…orch#38902)

Summary:
Add `store_artifacts` attribtue to Windows build jobs
In `vs_install.ps1` add logic to download vscollect tool and upload collected results as build artifacts
Pull Request resolved: pytorch#38902

Differential Revision: D21700598

Pulled By: malfet

fbshipit-source-id: b51c47ff44ac522ad5581624f5b9a9a86cf1e595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterjc123 peterjc123 peterjc123 approved these changes

+2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@pbelevich pbelevich pbelevich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @pbelevich @peterjc123 @mruberry