Fix SyncBatchNorm forward pass for non-default process group#38874
Closed
linziyi96 wants to merge 1 commit intopytorch:masterfrom
Closed
Fix SyncBatchNorm forward pass for non-default process group#38874linziyi96 wants to merge 1 commit intopytorch:masterfrom
linziyi96 wants to merge 1 commit intopytorch:masterfrom
Conversation
vkuzo
approved these changes
May 21, 2020
Contributor
vkuzo
left a comment
There was a problem hiding this comment.
Thanks! sorry for missing this case
|
Is there a reason this hasn't been merged yet. This is a pretty nasty bug when you don't run the same operations on every device and slows down training speed. |
Contributor
|
@linziyi96 , any chance you can rebase so we can run recent CI? Or, happy to put up a new PR and link this one. |
vkuzo
added a commit
that referenced
this pull request
Aug 30, 2020
Contributor
|
#43861 which is a redo of this PR is landing now, sorry for the delay! |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#43861) Summary: Pull Request resolved: pytorch#43861 This is a redo of pytorch#38874, and fixing my original bug from pytorch#38246. Test Plan: CI Imported from OSS Reviewed By: supriyar Differential Revision: D23418816 fbshipit-source-id: 2a3a3d67fc2d03bb0bf30a87cce4e805ac8839fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In forward pass of SyncBN, the all_gather call ignores process_group, leading to failure if any non-default process group is used,
Seems to be introduced quite recently by #38246.